Last modified: 2014-01-30 10:39:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61955, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59955 - BetaFeatures: Add number of "Automatically enable all new beta features" users on Special:Preferences (as tooltip?)
BetaFeatures: Add number of "Automatically enable all new beta features" user...
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
BetaFeatures (Other open bugs)
REL1_22-branch
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: design, easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-11 20:43 UTC by db [inactive,noenotif]
Modified: 2014-01-30 10:39 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2014-01-11 20:43:00 UTC
All others preferences for BetaFeatures have a number about the user which use that, but this has not, please add. Thanks.
Comment 1 MZMcBride 2014-01-11 20:49:26 UTC
I believe this number is stored, so it should be trivial to expose. It's mostly a design question. Jared: thoughts?
Comment 2 Jared Zimmerman (WMF) 2014-01-12 00:07:21 UTC
Maybe as a tooltip, but otherwise i think it unnecessarily clutters the UI, and would make the text for the action harder to parse for people.
Comment 3 Andre Saboia 2014-01-13 19:51:36 UTC
this number it is not stored. this extension have a betafeatures_user_counts table that store the number of users of some extensions used... but there is no default row for store the "Automatically enable all new beta features" users number. so I believe that will be needed to add a default row in the sql scrept, to store this number.
Comment 4 Mark Holmquist 2014-01-14 00:32:47 UTC
Honestly it's probably specifically *excepted* from the query that updates the rows, so you could probably add it in pretty quickly.

If not, adding another value also shouldn't be too hard.

You don't need to add a row, it will be possible to do this without changing the schema, you just need to add another criterion ("OR feature_name = betafeatures-auto-enroll" or something) that will also add the list for this, then surface that number in the UI.

And maybe add a cache for it.
Comment 5 Gerrit Notification Bot 2014-01-29 21:41:08 UTC
Change 110238 had a related patch set uploaded by Mno2:
BetaFeatures: Show number of users who enabled auto-enroll option

https://gerrit.wikimedia.org/r/110238
Comment 6 Andre Saboia 2014-01-29 22:13:35 UTC
I and a team that I am working with, are learning how to contribute with the MediaWiki, and this maybe will be our first contribution :D.

So we just have submitted the patch Gerrit change #110238, and the basic idea is that we added:

$wgHooks['GetBetaFeaturePreferences'][] = BetaFeaturesHooks::getBetaPreferences';

Then, the BetaFeature auto-enroll option will be handled as any other features, and the number of users will be counted normally.

But since its not needed to show the auto-enroll option like the other beta features in the list. We ignore the auto-enroll in the for loop that show the list, and we show the auto-enroll option, as before, just changing the HTMLFormField to another one that was created.
Comment 7 Andre Klapper 2014-01-30 10:39:50 UTC
(In reply to comment #6)
> I and a team that I am working with, are learning how to contribute with the
> MediaWiki, and this maybe will be our first contribution :D.
> 
> So we just have submitted the patch Gerrit change #110238

Hi Andre, this is very welcome! 
If you need any help, don't hesitate to ask!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links