Last modified: 2014-02-11 14:44:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62036, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60036 - LivePreview: Wrong skin when using useskin
LivePreview: Wrong skin when using useskin
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: 1.23.0 release
Assigned To: Fomafix
:
Depends on:
Blocks: 39272
  Show dependency tree / graph
 
Reported: 2014-01-14 12:45 UTC by Fomafix
Modified: 2014-02-11 14:44 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Live Preview of https://en.wikipedia.org/w/index.php?title=MediaWiki&action=edit&useskin=vector with monobook as default skin. (237.22 KB, image/png)
2014-01-15 07:16 UTC, Fomafix 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Fomafix 2014-01-14 12:45:20 UTC 
Steps to reproduce:
* Set in [[Special:Preferences]]
** Skin "Vector".
** Enable "Use live preview".
* Open https://en.wikipedia.org/w/index.php?title=MediaWiki&action=edit&useskin=monobook
* Click on "Show preview".
The languages on the left side has the design from skin Vector.

Expected result: Show the languages in the design of the current skin instead of the design of the skin of the user settings.

Solution: Use current skin for preview loading.
Comment 1 Gerrit Notification Bot 2014-01-14 12:49:36 UTC 
Change 107359 had a related patch set uploaded by Gerrit Patch Uploader:
(Bug 60036) Use current skin for live preview

https://gerrit.wikimedia.org/r/107359
Comment 2 Gerrit Notification Bot 2014-01-14 14:07:12 UTC 
Change 107359 had a related patch set uploaded by Gerrit Patch Uploader:
Use current preference overriding for live preview

https://gerrit.wikimedia.org/r/107359
Comment 3 Fomafix 2014-01-15 07:16:15 UTC 
Created attachment 14316 [details]
Live Preview of https://en.wikipedia.org/w/index.php?title=MediaWiki&action=edit&useskin=vector with monobook as default skin.
Comment 4 Bartosz Dziewoński 2014-02-11 14:41:34 UTC 
Thanks for the fix!
Comment 5 Gerrit Notification Bot 2014-02-11 14:44:28 UTC 
Change 107359 merged by jenkins-bot:
Use current preference overriding for live preview

https://gerrit.wikimedia.org/r/107359
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links