Last modified: 2014-01-15 17:40:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62078, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60078 - Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese
Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Tomasz W. Kozlowski
https://zh.wikivoyage.org
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-15 09:34 UTC by Gabriel Chi Hong Lee
Modified: 2014-01-15 17:40 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Chi Hong Lee 2014-01-15 09:34:21 UTC
The logo in zh.wikivoyage should change according to the language settings like zh-hant, zh-hans, zh-hk... But in every language it still shows the same logo in zh-hans.
Links to different language with the logo:
zh-hans:  http://s23.postimg.org/pnnm08knr/zh_hans.png
zh-hant:  http://s23.postimg.org/893dryniv/zh_hant.png
zh-hk:    http://s23.postimg.org/i8ya7uys7/zh_hk.png
Comment 1 Andre Klapper 2014-01-15 09:38:50 UTC
[Moving to "Wikimedia" product as this request is about settings / configuration of the website, not about the codebase of MediaWiki itself.]
Comment 2 Tomasz W. Kozlowski 2014-01-15 10:28:22 UTC
I don't think this is a Bugzilla bug; the Chinese Wikipedia appears to be using some sort of JavaScript to present different logos per different language variants.

I haven't been able to find anything in [[zh:MediaWiki:Common.js]], so I think it's cleverly hidden in some gadget; please contact the Chinese Wikipedia community for help.
Comment 3 Byfserag 2014-01-15 11:37:16 UTC
(In reply to comment #2)
> I don't think this is a Bugzilla bug; the Chinese Wikipedia appears to be
> using
> some sort of JavaScript to present different logos per different language
> variants.
> 
> I haven't been able to find anything in [[zh:MediaWiki:Common.js]], so I
> think
> it's cleverly hidden in some gadget; please contact the Chinese Wikipedia
> community for help.

No,it isn't.
https://git.wikimedia.org/blob/operations%2Fmediawiki-config/9c822a18d0382d8943691fe76405d8bc7f292161/wmf-config%2FInitialiseSettings.php#L637 

https://git.wikimedia.org/blob/operations%2Fmediawiki-config/9c822a18d0382d8943691fe76405d8bc7f292161/wmf-config%2FInitialiseSettings.php#L920
Comment 4 Tomasz W. Kozlowski 2014-01-15 11:57:00 UTC
True; we'd need to change the logo to $stdlogo first. Thanks for catching this!
Comment 5 Gerrit Notification Bot 2014-01-15 12:05:33 UTC
Change 107566 had a related patch set uploaded by Odder:
Enable setting logo per language variant on zh.voy

https://gerrit.wikimedia.org/r/107566
Comment 6 Liangent 2014-01-15 17:19:46 UTC
This can't be done in PHP. $stdlogo refers to Wiki.png on site. Ctrl+F for #p-logo in zhwiki's MediaWiki:Common.css.
Comment 7 Tomasz W. Kozlowski 2014-01-15 17:21:28 UTC
No shit.
Comment 8 Liangent 2014-01-15 17:25:22 UTC
(In reply to comment #7)
> No shit.

What?
Comment 9 Liangent 2014-01-15 17:28:04 UTC
To clarify, that patch doesn't do what it claims by "enable the community to set different logos per language variant (zh-hans, zh-hant, etc.)". This is not required by the hack used on zhwiki. If using $stdlogo is expected for easier logo change in the future, that patch works.
Comment 10 Gerrit Notification Bot 2014-01-15 17:39:56 UTC
Change 107566 abandoned by Odder:
Enable setting logo per language variant on zh.voy

https://gerrit.wikimedia.org/r/107566
Comment 11 Tomasz W. Kozlowski 2014-01-15 17:40:21 UTC
Turns out they use CSS[1] for it, not JavaScript as I thought, so they can do with a pre-defined logo.

* [1] https://zh.wikipedia.org/wiki/MediaWiki:Common.css

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links