Last modified: 2014-02-25 18:25:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62099, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60099 - multimediaviewer-repository contains the name of the local wiki instead of the remote repository when using InstantCommons
multimediaviewer-repository contains the name of the local wiki instead of th...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-15 19:09 UTC by Dereckson
Modified: 2014-02-25 18:25 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dereckson 2014-01-15 19:09:15 UTC
On a wiki not using a full remote repository configuration but using the InstantCommons quick settings, the multimediaviewer-repository message contains the local wiki name.

[ Bug analysis ]

This remote repository name is defined in the LIP.setRepoDisplayName method:
displayname = displayname || mw.config.get( 'wgSiteName' );

This method is called in resources/ext.multimediaViewer/ext.multimediaViewer.js:
ui.setRepoDisplayName( repoData.displayname, repoData.isLocal );

The bug has been introduced in change Ife8293c86683ea914b1a5a60000584b501d92e55 and the new data model, where repoData.displayname doesn't seem to be set when using $wgInstantCommons instead of a full foreign repository configuration.
Comment 1 Tisza Gergő 2014-01-15 19:22:39 UTC
This doesn't have anything to do with 'full' vs. 'quick' settings ($wgUseInstantCommons is just a shortcut for a given set of full settings, anyway) - I think it's caused by displayName being misspellt as displayname at a few places. IIRC that has just been fixed (maybe not merged yet?).
Comment 2 Dereckson 2014-01-15 20:27:31 UTC
[ Adding code-update-regression keyword. ]
Comment 3 Gilles Dubuc 2014-02-20 09:43:42 UTC
Could you please check if this is still happening with the latest master?
Comment 4 Gilles Dubuc 2014-02-25 16:52:17 UTC
Gergo, do you think this might have been fixed by https://gerrit.wikimedia.org/r/#/c/115314/  ? Or is it totally unrelated?
Comment 5 Tisza Gergő 2014-02-25 18:25:31 UTC
Unrelated, that commit only affected favicons.

I think this was caused by a bug that was fixed a long time ago, and I cannot reproduce it locally. I'm closing the bug; Dereckson, please reopen if you still experience it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links