Last modified: 2014-03-10 10:14:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62106, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60106 - Jenkins triggering false failures occasionally on parsoid patches
Jenkins triggering false failures occasionally on parsoid patches
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-15 21:18 UTC by ssastry
Modified: 2014-03-10 10:14 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2014-01-15 21:18:50 UTC
In recent days, we've often run into this issue where a patch passes parser tests after submit, but fails after +2 in the gate-and-submit pipeline.

* https://gerrit.wikimedia.org/r/#/c/106284/
* https://gerrit.wikimedia.org/r/#/c/107600/
* https://gerrit.wikimedia.org/r/#/c/107605

Looking at jenkins full console log for one the failing run for gerrit patch 106284 above (https://integration.wikimedia.org/ci/job/parsoidsvc-parsertests-run-harder/211/consoleFull), we see this:
-----------
17:59:40 + git checkout FETCH_HEAD
17:59:40 Warning: you are leaving 45 commits behind, not connected to
17:59:40 any of your branches:
-----------

That looks quite odd ... why would we be leaving behind 45 commits? That indicates a bad checkout somehow.

Look at full console log for a failing run for gerrit patch 107600 (https://integration.wikimedia.org/ci/job/parsoidsvc-parsertests-run-harder/286/consoleFull), we see this:
------------
19:46:07 + git checkout FETCH_HEAD
19:46:07 Warning: you are leaving 2 commits behind, not connected to
19:46:07 any of your branches:
------------

But, Looking at jenks full console log for the final passing run for gerrit patch 107600 (https://integration.wikimedia.org/ci/job/parsoidsvc-parsertests-run-harder/288/consoleFull), we see this:

----------- 
19:51:12 + git checkout FETCH_HEAD
19:51:12 Warning: you are leaving 1 commit behind, not connected to
19:51:12 any of your branches:
-----------

This looks more reasonable.
Comment 1 Gerrit Notification Bot 2014-03-05 21:06:11 UTC
Change 117045 had a related patch set uploaded by Hashar:
Parsoid: uses ZUUL_COMMIT as a git refspec to build

https://gerrit.wikimedia.org/r/117045
Comment 2 Gerrit Notification Bot 2014-03-10 10:14:32 UTC
Change 117045 merged by jenkins-bot:
Parsoid: uses ZUUL_COMMIT as a git refspec to build

https://gerrit.wikimedia.org/r/117045
Comment 3 Antoine "hashar" Musso (WMF) 2014-03-10 10:14:48 UTC
I am pretty sure https://gerrit.wikimedia.org/r/#/c/117045/ fixed the issue, i.e. to use a branch specifier in the Jenkins Git plugin to discard its heuristic when finding which commit to build.  That was hitting us previously (bug 46723) and the fix is fairly easy.

I have updated all the jobs:

parsoid-parse-tool-check
parsoid-parsertests-run
parsoid-parsertests-run-harder
parsoid-php-parsertests
parsoid-regressions
parsoid-roundtrip-test-check
parsoidsvc-php-parsertests

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links