Last modified: 2014-09-12 17:56:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62134, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60134 - Include /* section title */ in edit summary for mobile section edits
Include /* section title */ in edit summary for mobile section edits
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Nobody - You can work on this!
: design, easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-16 15:14 UTC by Liangent
Modified: 2014-09-12 17:56 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2014-01-16 15:14:18 UTC
So page history is easier to read.
Comment 1 Bingle 2014-01-16 15:30:28 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1631
Comment 2 Jon 2014-04-18 17:41:47 UTC
Jared/Kenan is this something we want?
Comment 3 Jared Zimmerman (WMF) 2014-04-18 17:43:04 UTC
sure? maybe stripping out the extra character though, doesn't seem necessary
Comment 4 Jared Zimmerman (WMF) 2014-04-18 17:43:24 UTC
sure? maybe stripping out the extra character though, doesn't seem necessary
Comment 5 Gerrit Notification Bot 2014-05-25 13:42:30 UTC
Change 135311 had a related patch set uploaded by Florianschmidtwelzow:
Insert section name in edit summary

https://gerrit.wikimedia.org/r/135311
Comment 6 Florian 2014-05-25 13:51:22 UTC
I'm very unsure, if this is the best solution to get the new sections name, any suggestions i overlook?
Comment 7 Liangent 2014-05-25 15:37:43 UTC
(In reply to Florian from comment #6)
> I'm very unsure, if this is the best solution to get the new sections name,
> any suggestions i overlook?

1. When the title is "== [[section]] ==", the output on desktop is /* section */ while MF now outputs /* [[section]] */

2. When the section title got changed in an edit, desktop uses the original section title while MF uses the new one (if I read your code correctly)

I'm not sure which is better, but at least they're inconsistent.
Comment 8 Jon 2014-05-27 18:14:50 UTC
Can I suggest we do not pre-fill the edit summary and instead auto prepend it programatically?

I worry seeing /* Section History */ in an input box might be off putting to a user not familiar with wiki editing and might lead to them not adding edit summaries... (although I have no evidence to back this up)
Comment 9 Florian 2014-05-27 18:19:46 UTC
Hmm, it's an argument, the other side is, that, if we look at consistency between desktop and mobile edit, a pre filled summary with the section name is an obligation. But i see the possible problem like you :/
Comment 10 Florian 2014-06-04 20:57:16 UTC
Maybe adding section name without show this to user (maybe only, if the user entered a summary)?
Comment 11 Yuvi Panda 2014-06-04 20:59:01 UTC
(In reply to Florian from comment #10)
> Maybe adding section name without show this to user (maybe only, if the user
> entered a summary)?

Mobile Apps do a slight variation of this. They prepend the section name automatically all the time, even if the user didn't enter any
Comment 12 Florian 2014-06-04 21:02:37 UTC
Ok. The thing to add section name only, if the user enteres a summary is a maybe :) maybe the behavior can be configureable for wiki administrators with a config variable (default to true).
Comment 13 Florian 2014-06-10 08:49:01 UTC
Any opinions? :)
Comment 14 Florian 2014-06-27 09:14:40 UTC
Any progress? I prefer the App solution.
Comment 15 Gerrit Notification Bot 2014-09-12 17:53:11 UTC
Change 135311 merged by jenkins-bot:
Insert section name in edit summary

https://gerrit.wikimedia.org/r/135311

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links