Last modified: 2014-11-20 01:41:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62138, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60138 - Jenkins: JSDuck should run on Ruby 1.9 instead of Ruby 1.8
Jenkins: JSDuck should run on Ruby 1.9 instead of Ruby 1.8
Status: NEW
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-16 16:42 UTC by Bartosz Dziewoński
Modified: 2014-11-20 01:41 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-01-16 16:42:24 UTC
jenkins is still using Ruby 1.8 when generating/testing JSDuck documentation. 1.8 was EOL'd last June (https://www.ruby-lang.org/en/news/2013/06/30/we-retire-1-8-7/) and the current version is 2.1.

JSDuck 4 runs perfectly well on newer versions, I think you could upgrade to at least 1.9 with no hiccups.

I noticed this when looking at a segfault that happened on this job:
https://integration.wikimedia.org/ci/job/mediawiki-core-jsduck/3304/console
– upgrading Ruby will probably fix this kind of problems too.
Comment 1 Antoine "hashar" Musso (WMF) 2014-01-16 22:00:12 UTC
On Ubuntu Precise the default ruby version is 1.8.7.  We have both 1.9.1 and 1.9.3 already installed on slaves so it a matter of figuring out how to run jsduck with the other ruby version :-]
Comment 2 Antoine "hashar" Musso (WMF) 2014-01-31 09:54:52 UTC
The stacktrace only happened once apparently, not sure it is related to ruby 1.8.x.  Since using ruby 1.9 is unlikely to enhance our jsduck run, I am closing this bug.
Comment 3 Bartosz Dziewoński 2014-01-31 11:23:26 UTC
Ruby 1.8 is past its EOL. We should not be using obsolete software which is no longer receiving bug fixes.
Comment 4 Antoine "hashar" Musso (WMF) 2014-01-31 19:48:55 UTC
Ruby 1.8 is the default on Precise. And since it is used by puppet among other, I would prefer to stick to it for now :-D
Comment 5 Bartosz Dziewoński 2014-01-31 20:31:26 UTC
MediaWiki 1.15 is also the default on Precise, you know.

The fact that Ubuntu/Debian uses obsolete software doesn't mean we should be using obsolete software. But, well, you're the boss here :)
Comment 6 Bartosz Dziewoński 2014-02-20 03:20:37 UTC
I've gotten a segfault again. https://gerrit.wikimedia.org/r/#/c/114400/1
Comment 7 Krinkle 2014-02-20 03:24:34 UTC
(In reply to Bartosz Dziewoński from comment #6)
> I've gotten a segfault again. https://gerrit.wikimedia.org/r/#/c/114400/1

https://integration.wikimedia.org/ci/job/mediawiki-core-jsduck/3595/console

See https://github.com/senchalabs/jsduck/issues/353.

Using upstream recommended workaround as of I1c8dac8dcf537a4a.
Comment 8 Bartosz Dziewoński 2014-02-20 11:27:10 UTC
The job is still segfaulting. https://gerrit.wikimedia.org/r/#/c/114373/

Was the fix deployed?
Comment 9 Antoine "hashar" Musso (WMF) 2014-02-20 22:03:10 UTC
Reopening per Timo comment #7. There is a workaround which is to disable parallel processing.

Fix is described at https://gerrit.wikimedia.org/r/#/c/114401/

I have refreshed the two jsduck jobs in Jenkins. We will see whether the workaround works.
Comment 10 Antoine "hashar" Musso (WMF) 2014-09-18 07:53:14 UTC
Thanks to Timo, we now have Ubuntu Trusty instances which comes by default with:

 $ ruby --version
 ruby 1.9.3p484 (2013-11-22 revision 43786) [x86_64-linux]
 $

We can get the JSDuck jobs to run on Trusty node by having them tied to labels UbuntuTrusty && contintLabsSlave  then use the jjb push-doc macro to publish to doc.wikimedia.org as described on http://www.mediawiki.org/wiki/Continuous_integration/Documentation_generation

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links