Last modified: 2014-02-03 21:38:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62152, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 60152 - Flow: avoiding cache bugs


Summary:	Flow: avoiding cache bugs

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Flow (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-01-16 21:35 UTC by spage
Modified:	2014-02-03 21:38 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-01-16 21:35:32 UTC

bug 59884 was caused by the typo:

  $pathKey = wfForeignMemcKey( 'flow', '', 'tree', 'rootpath', $descendant->getHex() );
    $cacheKeys[$descendant->getHex()] = wfForeignMemcKey( 'flow', 'tree', 'rootpath', $descendant->getHex() );

The initial conclusion was
* write caching tests that would fail in this case with "Item should be in cache".

But we could avoid the bug by: 
* eliminate typo by using a constant for the cache key.
**  add a class method to generate the cache key.
***   have a high-level class implement cacheThis => true

Comment 1 Bingle 2014-01-16 21:45:27 UTC

The WMF core features team tracks this bug on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/724, but people from the community are welcome to contribute here and in Gerrit.

Comment 2 Gerrit Notification Bot 2014-01-31 00:05:49 UTC

Change 110472 had a related patch set uploaded by Bsitu:
Add cacheKey function and tests to TreeRepository + typo fix

https://gerrit.wikimedia.org/r/110472

Comment 3 Gerrit Notification Bot 2014-02-03 21:22:06 UTC

Change 110472 merged by jenkins-bot:
Add cacheKey function and tests to TreeRepository + typo fix

https://gerrit.wikimedia.org/r/110472

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links