Last modified: 2014-09-04 13:47:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62155, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60155 - Flow: viewing a moderated topic you don't have userrights to see, shows error page
Flow: viewing a moderated topic you don't have userrights to see, shows error...
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://ee-flow.wmflabs.org/wiki/User_...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-17 01:12 UTC by spage
Modified: 2014-09-04 13:47 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-01-17 01:12:27 UTC
If a topic is hidden/deleted/suppressed, and you don't have the rights to unhide or restore it (e.g. you're not logged in), then you don't see the topic box at all.  This is great on a Flow board, spam is invisible for people who can't reveal it.

But if you follow a link to a flagged topic and don't have the rights, you see an empty page containing just 
   <Flow board name in h1>
It looks broken.

If you have the rights, then you see 
    <topic title in h1>
    "This topic was started on <Flow board name>" gray link line
    [This topic was deleted by Admin] topic box

I think users without rights to unhide/restore should see something like
   "Flagged content" as h1
   "This flagged topic was started on <Flow board name>" gray link line

the details will change if we add a crumbtrail from topic back to post.
Comment 1 Bingle 2014-01-17 01:18:30 UTC
The WMF core features team tracks this bug on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/725, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Quiddity 2014-08-03 16:50:18 UTC
Viewing a deleted topic, as a non-admin, gets an error page:
eg. https://www.mediawiki.org/wiki/Topic:Ryqpaslvstkeunf1
gives:

PHP fatal error in /usr/local/apache/common-local/php-1.24wmf16/extensions/Flow/includes/Templating.php line 231:
Argument 1 passed to Flow\Templating::getContent() must be an instance of Flow\Model\AbstractRevision, null given, called in /usr/local/apache/common-local/php-1.24wmf16/extensions/Flow/includes/Block/Topic.php on line 490 and defined 

but an admin sees the normal collapsed white topic box.


(possibly related to bug 67595 ?)

Reported at https://www.mediawiki.org/wiki/Topic:Rz7mob6cmup1bosc
Comment 3 Jon 2014-09-04 13:47:23 UTC
This no longer causes a fatal error.
If I follow the link Quiddity posted in #c2 I can see the heading error and it tells me I don't have permission.

I don't think there is anything left to do here!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links