Last modified: 2014-03-25 22:04:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62156, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60156 - CodeEditor doesn't automatically type matching closing } when I type {
CodeEditor doesn't automatically type matching closing } when I type {
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeEditor (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-17 02:05 UTC by Gryllida
Modified: 2014-03-25 22:04 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gryllida 2014-01-17 02:05:05 UTC
Typing "{" is expected to produce this output:

-----------------------------------
{<cursor here>}
-----------------------------------

Now, it produces this instead, at test.wikipedia.org:

-----------------------------------
{<cursor here>
-----------------------------------

It also works at en.wikipedia.org right now, and it worked at test.wikipedia.org yesterday.
Comment 1 Jackmcbarn 2014-01-17 02:38:37 UTC
Are you sure it's supposed to add a matching brace?
Comment 2 Gryllida 2014-01-17 04:11:00 UTC
Re-read last line of comment 1.
It was convenient.
Comment 3 Gryllida 2014-01-17 04:11:27 UTC
(In reply to comment #2)
> Re-read last line of comment 1.
> It was convenient.

Sorry, of the description, not of comment 1.
Comment 4 Jackmcbarn 2014-01-17 04:16:20 UTC
It seems likely that it broke in 1.23wmf11, which just deployed to testwp yesterday (and isn't on enwp yet). I can definitely confirm it now.
Comment 5 Derk-Jan Hartman 2014-01-17 06:12:55 UTC
I'll inquire with the ACE developers if there is any known issue in their last release.  It seems to work just fine in their trunk version http://ace.c9.io/build/kitchen-sink.html if you "enable behaviours".

but if i do that in the MW version (which is the december ACE release), i don't see any result.
Comment 6 Derk-Jan Hartman 2014-01-17 06:26:33 UTC
Since I'm getting on a plane within 24h: https://github.com/ajaxorg/ace/issues/1770
Comment 7 Derk-Jan Hartman 2014-01-17 10:19:44 UTC
Confirmed that it was broken in the release that I updated CodeEditor to. I'll submit a new update into gerrit soon
Comment 8 Gerrit Notification Bot 2014-01-17 15:20:24 UTC
Change 108050 had a related patch set uploaded by TheDJ:
Update ACE to Jan 17, 2014

https://gerrit.wikimedia.org/r/108050
Comment 9 Gerrit Notification Bot 2014-01-19 07:37:15 UTC
Change 108050 merged by jenkins-bot:
Update ACE to Jan 17, 2014

https://gerrit.wikimedia.org/r/108050
Comment 10 Jackmcbarn 2014-01-29 02:42:12 UTC
The patch does not appear to have fixed the problem on the beta cluster.
Comment 11 Gerrit Notification Bot 2014-03-16 18:53:54 UTC
Change 118979 had a related patch set uploaded by TheDJ:
Update ACE to Mar 16, 2014

https://gerrit.wikimedia.org/r/118979
Comment 12 Gerrit Notification Bot 2014-03-25 17:47:02 UTC
Change 118979 merged by jenkins-bot:
Update ACE to Mar 16, 2014

https://gerrit.wikimedia.org/r/118979
Comment 13 Derk-Jan Hartman 2014-03-25 22:04:43 UTC
This is fixed in master. Will roll out to the various wiki's in the next two week.s

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links