Last modified: 2014-03-11 20:11:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62198, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60198 - In Review mode on a translation group, it displays raw wikicode, but whitespace is not preserved
In Review mode on a translation group, it displays raw wikicode, but whitespa...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Tina Johnson ( tinaj1234 )
https://www.mediawiki.org/w/index.php...
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-18 11:41 UTC by Jesús Martínez Novo (Ciencia Al Poder)
Modified: 2014-03-11 20:11 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Review translations: newlines in code are rendered as spaces (106.82 KB, image/png)
2014-01-18 11:41 UTC, Jesús Martínez Novo (Ciencia Al Poder)
Details

Description Jesús Martínez Novo (Ciencia Al Poder) 2014-01-18 11:41:03 UTC
Created attachment 14336 [details]
Review translations: newlines in code are rendered as spaces

When translating a group of messages, and you go to Review mode, it displays raw wikitext in both sides, which is good, but whitespace is not preserved, so newlines are being displayed as single spaces, and messages that contains unordered lists looks like they would be messed up.

See screenshot.

If we are displaying raw wikitext, we should output it as seen in the textarea, preserving all whitespace, so newlines in code are displayed as such.
Comment 1 Jesús Martínez Novo (Ciencia Al Poder) 2014-01-18 11:44:30 UTC
Having the following CSS applied would solve the issue:

.tux-proofread-translation, .tux-proofread-source { white-space: pre-wrap; }
Comment 2 Tina Johnson ( tinaj1234 ) 2014-01-19 12:02:37 UTC
I would like to prepare a patch for this.
Comment 3 Tony Thomas 2014-01-19 12:04:39 UTC
Prepare the patch 
www.mediawiki.org/wiki/Gerrit/Tutorial
Comment 4 Gerrit Notification Bot 2014-01-19 13:59:34 UTC
Change 108330 had a related patch set uploaded by Tinaj1234:
Added CSS to preserve whitespace

https://gerrit.wikimedia.org/r/108330
Comment 5 Gerrit Notification Bot 2014-01-22 05:50:52 UTC
Change 108330 merged by jenkins-bot:
Added CSS to existing selector: preserve whitespace in review mode

https://gerrit.wikimedia.org/r/108330
Comment 6 Andre Klapper 2014-03-11 17:01:35 UTC
Patch merged in comment 5 - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.
Comment 7 Jesús Martínez Novo (Ciencia Al Poder) 2014-03-11 20:11:04 UTC
Verified with the provided link (test-case)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links