Last modified: 2014-02-12 23:54:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62251, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60251 - DISPLAYTITLE is not used after mobile edit
DISPLAYTITLE is not used after mobile edit
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-20 08:48 UTC by Liangent
Modified: 2014-02-12 23:54 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2014-01-20 08:48:46 UTC 
Repro:

1. Go to https://en.m.wikipedia.org/wiki/IPhone
2. Click the pencil button
3. Do some random edit
4. "Continue" -> "Save"
5. "IPhone" is now shown in page title <title> and heading <h1>,
instead of "iPhone".
Comment 1 Bingle 2014-01-20 08:55:28 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1638
Comment 2 Theopolisme 2014-01-20 16:45:28 UTC 
Hmm, I wonder if this is by design. DISPLAYTITLE is *not* the page title, and to show it as the title would be misleading, not to mention potentially confusing -- imagine that the user modifies the DISPLAYTITLE in the process of editing the page. Then what do we do?

The desktop version of MediaWiki ignores the template when showing the edit interface (both in the <title> and header), see <https://en.wikipedia.org/w/index.php?title=IPhone&action=edit> For consistency, we should probably do the same.
Comment 3 Theopolisme 2014-01-20 16:52:44 UTC 
Oh wait, I see what you're saying, sorry about that -- I was thinking of the other bug :P Hmm, I'll need to look into this..
Comment 4 Theopolisme 2014-01-20 18:34:42 UTC 
Working on this now.
Comment 5 Gerrit Notification Bot 2014-01-20 19:18:25 UTC 
Change 108539 had a related patch set uploaded by Theopolisme:
Use DISPLAYTITLE when rendering pages

https://gerrit.wikimedia.org/r/108539
Comment 6 Jon 2014-01-21 17:59:32 UTC 
For those who don't know what DISPLAYTITLE is see https://en.wikipedia.org/wiki/Template:DISPLAYTITLE
Comment 7 Gerrit Notification Bot 2014-02-03 19:51:33 UTC 
Change 108539 merged by jenkins-bot:
Use DISPLAYTITLE when rendering pages

https://gerrit.wikimedia.org/r/108539
Comment 8 MZMcBride 2014-02-03 19:56:54 UTC 
(In reply to comment #6)
> For those who don't know what DISPLAYTITLE is see
> https://en.wikipedia.org/wiki/Template:DISPLAYTITLE

That's a local wrapper template. "DISPLAYTITLE" is a MediaWiki core parser function (cf. [[mw:Help:Magic words]]).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links