Last modified: 2014-01-30 18:40:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62262, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 60262 - parsoid should allow binding to a specific IP or interface


Summary:	parsoid should allow binding to a specific IP or interface

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement
Target Milestone:	---
Assigned To:	Gabriel Wicke

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-01-20 19:11 UTC by Kevin Stange
Modified:	2014-01-30 18:40 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kevin Stange 2014-01-20 19:11:09 UTC

I would like to have parsoid bind to localhost.  This is a simple patch for me, but I think it should be an option so I don't have to modify the server.js file:

-       app.listen(process.env.VCAP_APP_PORT || 8000);
+       app.listen(process.env.VCAP_APP_PORT || 8000, 'localhost');

For me, binding only to localhost just reduces the exposure of parsoid for a private wiki.  In some cases, I could see wanting to bind to a specific interface to point parsoid toward a private network or something similar.

Comment 1 Arlo Breault 2014-01-20 20:40:03 UTC

Would this best be exposed through localsetting.js, environment variable or command line option?

Comment 2 Kevin Stange 2014-01-20 21:03:42 UTC

Since the port is currently an environmental variable, it makes sense to do this the same way.  If the long term goal is to push more settings into the configuration file, then maybe that's the right place to go.

Comment 3 Gerrit Notification Bot 2014-01-29 21:03:40 UTC

Change 110230 had a related patch set uploaded by Arlolra:
Add port and host env vars to ParsoidService

https://gerrit.wikimedia.org/r/110230

Comment 4 Gerrit Notification Bot 2014-01-30 17:08:00 UTC

Change 110230 merged by jenkins-bot:
Add port and host env vars to ParsoidService

https://gerrit.wikimedia.org/r/110230

Comment 5 Arlo Breault 2014-01-30 18:40:19 UTC

Now exposed as PARSOID_PORT & PARSOID_HOST.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links