Last modified: 2014-04-16 21:36:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62289, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60289 - C_FORCE_ROOT is bad, change pickle as serialization format for celery
C_FORCE_ROOT is bad, change pickle as serialization format for celery
Status: NEW
Product: Analytics
Classification: Unclassified
Wikimetrics (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Charles Salvia
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-21 16:22 UTC by Dan Andreescu
Modified: 2014-04-16 21:36 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Dan Andreescu 2014-01-21 16:22:33 UTC 
To fix a recent bug I had to upgrade celery.  But this highlighted that we have a security issue due to Celery running as root and pickle being the default serialization format.  We need to:

1. stop running Celery as root (configure upstart)
2. stop using pickle as the serialization format
Comment 1 Bingle 2014-01-28 22:01:01 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/analytics/cards/cards/1396
Comment 2 Charles Salvia 2014-01-29 14:48:08 UTC 
Going to change pickle to JSON
Comment 3 Ori Livneh 2014-01-29 14:57:47 UTC 
(In reply to comment #0)
> 1. stop running Celery as root (configure upstart)

The Puppet module provisions an Upstart job which sets gid/uid to wikimetrics.
Comment 4 Dan Andreescu 2014-01-29 15:59:36 UTC 
Thanks Ori, that's a good point.  Wikimetrics came before its puppetization, so the "production" instance suffers from this problem.  We should fix it by puppetizing it.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links