Last modified: 2014-02-20 13:09:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62337, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60337 - :---- should give indent and <hr>
:---- should give indent and <hr>
Status: UNCONFIRMED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.23.0
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-22 13:27 UTC by Rezonansowy
Modified: 2014-02-20 13:09 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rezonansowy 2014-01-22 13:27:11 UTC
...but gives indent and ----  (4 dashes)
Comment 1 db [inactive,noenotif] 2014-01-25 11:41:15 UTC
Regex for this explicit ask for start of string or newline:

$text = preg_replace( '/(^|\n)-----*/', '\\1<hr />', $text );

in Parser.php::internalParse()

Looks like works as expected
Comment 2 Rezonansowy 2014-01-28 10:36:37 UTC
(In reply to comment #1)
> Regex for this explicit ask for start of string or newline:
> 
> $text = preg_replace( '/(^|\n)-----*/', '\\1<hr />', $text );
> 
> in Parser.php::internalParse()
> 
> Looks like works as expected

I've made an example, see https://en.wikipedia.org/w/index.php?title=User:Rezonansowy/sandbox&oldid=592775616
Comment 3 Ricordisamoa 2014-02-12 21:46:31 UTC
I believe it is working as expected, and I don't see why we should change that. Otherwise, it could break existing pages.
Comment 4 Rezonansowy 2014-02-20 13:09:34 UTC
(In reply to Ricordisamoa from comment #3)
> I believe it is working as expected, and I don't see why we should change
> that. Otherwise, it could break existing pages.

No it doesn't, it's a layout bug. Risk that it could break existing pages is very low, nobody codes using layout bugs as a target, besides for similar appearance we have the <nowiki /> tag.
Regards

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links