Last modified: 2014-02-25 11:11:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62367, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60367 - www.wikivoyage.org links to https://zh.wikipedia.org/zh-/ which is a 404
www.wikivoyage.org links to https://zh.wikipedia.org/zh-/ which is a 404
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: High normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
https://www.wikivoyage.org
:
Depends on: 60473
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-23 10:41 UTC by zhuyifei1999
Modified: 2014-02-25 11:11 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Byfserag 2014-01-23 12:06:27 UTC
Please set the keyword as i18n.
Comment 3 Andre Klapper 2014-01-23 12:26:47 UTC
Hi, where exactly and how to reproduce?

In the line
 Ελληνικά • עברית • Română • Svenska • Українська • 中文 
under the search field the link goes to
 https://zh.wikivoyage.org/
Comment 4 Sam Reed (reedy) 2014-01-23 17:47:15 UTC
This shouldn't be a bug on bugzilla. The portal exists at https://meta.wikimedia.org/wiki/Www.wikivoyage.org_template and should be fixed via meta
Comment 5 zhuyifei1999 2014-01-24 00:26:16 UTC
(In reply to comment #4)
> This shouldn't be a bug on bugzilla. The portal exists at
> https://meta.wikimedia.org/wiki/Www.wikivoyage.org_template and should be
> fixed
> via meta

Even if the portal template is right, the HTML given by the server is still wrong. 

(In reply to comment #3)
> Hi, where exactly and how to reproduce?
> 
> In the line
>  Ελληνικά • עברית • Română • Svenska • Українська • 中文 
> under the search field the link goes to
>  https://zh.wikivoyage.org/

Maybe because we've set "Content language variant" in our pref? I find the URL being "/zh-/" appended, and two other wikivoygers get "/zh-cn/" & "/zh-tw/".
Comment 6 zhuyifei1999 2014-01-24 00:38:41 UTC
Just found that there might actually a script causing this, as my browser gets the right URL in the first sec, and appended a wrong path a sec later.
Comment 7 PiRSquared17 2014-01-24 00:43:48 UTC
(In reply to comment #6)
> Just found that there might actually a script causing this, as my browser
> gets
> the right URL in the first sec, and appended a wrong path a sec later.

Yeah, this is obviously caused by https://meta.wikimedia.org/wiki/MediaWiki:Gadget-wm-portal.js

If you had reported on Meta I may have seen this faster, sorry.

Code snippet: $("zh_wiki").href += "zh-" + locale + "/";
Comment 8 PiRSquared17 2014-01-24 00:48:28 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > Just found that there might actually a script causing this, as my browser
> > gets
> > the right URL in the first sec, and appended a wrong path a sec later.
> 
> Yeah, this is obviously caused by
> https://meta.wikimedia.org/wiki/MediaWiki:Gadget-wm-portal.js
> 
> If you had reported on Meta I may have seen this faster, sorry.
> 
> Code snippet: $("zh_wiki").href += "zh-" + locale + "/";

Want me to just remove the locales for zhwikivoyage?
Comment 9 zhuyifei1999 2014-01-24 02:07:56 UTC
(In reply to comment #8)
> Want me to just remove the locales for zhwikivoyage?

Looks good to me.
Comment 10 Byfserag 2014-01-24 02:17:40 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > Want me to just remove the locales for zhwikivoyage?
> 
> Looks good to me.

It need some consensus,I think.
Comment 11 zhuyifei1999 2014-01-24 04:47:06 UTC
(In reply to comment #10)
> It need some consensus,I think.

Two ways to fix:
1. Remove the locales for zhwikivoyage.
2. Set $wgVariantArticlePath

True, removing the locales needs some consensus, but as $wgVariantArticlePath is not set, removing the locales IMO is a proper fix.
Comment 12 PiRSquared17 2014-01-24 18:02:28 UTC
Could you CC someone who knows how to set $wgVariantArticlePath? The easiest fix would just be to remove locales from www.wikivoyage.org, which is just a quick HTML edit on Meta. I'm not sure how you want this to be done. Is there consensus for either change?
Comment 13 zhuyifei1999 2014-01-25 02:53:49 UTC
(In reply to comment #12)
> Is there consensus for either change?

No consensus; we just spot the bug and reported it.
Comment 14 Gerrit Notification Bot 2014-01-25 03:50:03 UTC
Change 109456 had a related patch set uploaded by Reedy:
Set wgVariantArticlePath for zhwikivoyage

https://gerrit.wikimedia.org/r/109456
Comment 15 Gerrit Notification Bot 2014-01-25 03:50:22 UTC
Change 109456 merged by jenkins-bot:
Set wgVariantArticlePath for zhwikivoyage

https://gerrit.wikimedia.org/r/109456
Comment 16 Sam Reed (reedy) 2014-01-25 03:51:23 UTC
I've set wgVariantArticlePath as per other zh wikis
Comment 17 Tomasz W. Kozlowski 2014-01-25 12:31:36 UTC
This is now fixed.
Comment 18 Byfserag 2014-01-26 06:24:17 UTC
(In reply to comment #17)
> This is now fixed.

It's still 404.
https://zh.wikivoyage.org/zh-cn/
https://zh.wikivoyage.org/zh-tw/
Comment 19 zhuyifei1999 2014-01-26 07:30:23 UTC
Reopen since I can confirm comment #18 (still 404).
Comment 20 Byfserag 2014-01-26 07:46:04 UTC
Please set variant aliases on git operations/apache-config.
Comment 21 Tomasz W. Kozlowski 2014-01-26 10:27:45 UTC
Not what the bug says.
Comment 22 zhuyifei1999 2014-01-26 13:17:21 UTC
(In reply to comment #21)
> Not what the bug says.

Please revert. https://www.wikivoyage.org _does_ _link_ _to_ https://zh.wikipedia.org/zh-* _and_ _is_ _still_ 404
Comment 23 Tomasz W. Kozlowski 2014-01-26 13:30:01 UTC
https://meta.wikimedia.org/w/index.php?title=Www.wikivoyage.org_template&action=edit says otherwise.
Comment 24 Tomasz W. Kozlowski 2014-01-26 13:35:32 UTC
Ignore me today, I'm apparently blind or cannot read properly ;-)
Comment 25 PiRSquared17 2014-01-29 00:21:34 UTC
(In reply to comment #24)
> Ignore me today, I'm apparently blind or cannot read properly ;-)

Will /r/109456 fix this?
Comment 26 zhuyifei1999 2014-01-29 13:04:17 UTC
https://gerrit.wikimedia.org/r/#/c/110155/ hopfully will
Comment 27 Andre Klapper 2014-02-11 13:55:18 UTC
CC'ing Reedy to hopefully get this merged (three +1s) and deployed soon.
Comment 28 zhuyifei1999 2014-02-25 11:11:51 UTC
No longer 404 (bug 60473). Marking as FIXED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links