Last modified: 2014-02-26 15:55:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62489, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60489 - CirrusSearch: "prefix:" problems
CirrusSearch: "prefix:" problems
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-27 19:39 UTC by Nik Everett
Modified: 2014-02-26 15:55 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nik Everett 2014-01-27 19:39:39 UTC
We have some trouble with prefix.  All examples from dewiki:

> ```TMg prefix:Benutzer Diskussion:TMg``` was valid in the old search. According to Help:CirrusSearch it should be the same in the new search → bug.


> ```TMg prefix:"Benutzer Diskussion:TMg"``` should be possible if the space does have a different meaning now → missing feature.


> ```TMg prefix:Benutzer``` does not work but ```TMg prefix:Benutzer:``` does → missing feature.

It looks like some of this comes from us not doing the space to underscore transformation.  The rest looks like a prefix match on namespace.  That might be more complicated.
Comment 1 Gerrit Notification Bot 2014-02-04 15:57:48 UTC
Change 111204 had a related patch set uploaded by Manybubbles:
Handle space in namespace prefixed searches

https://gerrit.wikimedia.org/r/111204
Comment 2 Nik Everett 2014-02-04 15:59:02 UTC
Patch handles first case but not others so setting back to assigned.
Comment 3 Gerrit Notification Bot 2014-02-04 16:43:50 UTC
Change 111210 had a related patch set uploaded by Manybubbles:
Trim quotes from prefix: search

https://gerrit.wikimedia.org/r/111210
Comment 4 Nik Everett 2014-02-04 16:46:02 UTC
Neither of the patches on this bug handle the last issue but I'm not actually sure what the user thinks is wrong there so I've gone back to them on the talk page at https://www.mediawiki.org/wiki/Thread:Talk:Search/prefix:_search_for_localized_namespaces_broken/reply_%282%29
Comment 5 Gerrit Notification Bot 2014-02-04 17:42:57 UTC
Change 111204 merged by jenkins-bot:
Handle space in namespace prefixed searches

https://gerrit.wikimedia.org/r/111204
Comment 6 Gerrit Notification Bot 2014-02-04 17:45:52 UTC
Change 111210 merged by jenkins-bot:
Trim quotes from prefix: search

https://gerrit.wikimedia.org/r/111210
Comment 7 Nik Everett 2014-02-07 19:46:22 UTC
Looks like the last point wasn't really a bug, more of a feature request that is unfortunately complicated.  I'm happy to be wrong, in which case I'll open another bug.  For now, though, I'm marking this one resolved.
Comment 8 TMg 2014-02-26 15:47:15 UTC
(In reply to Nik Everett from comment #4)
> last issue [...] I'm not actually sure what the user thinks is wrong there

You are right, the last issue doesn't make much sense since it could mean two things: Search in that namespace or search for articles with that prefix. I think it's more sane to do the later.

Thank you very much for the fixes!
Comment 9 Nik Everett 2014-02-26 15:55:51 UTC
Thanks for working patiently with me to get the changes figured out and for verifying them!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links