Last modified: 2014-09-30 23:00:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62492, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60492 - ExtDynamicPageList::commonSetup() uses Title::exists() and causes problems in update.php
ExtDynamicPageList::commonSetup() uses Title::exists() and causes problems in...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
DynamicPageList2 (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 71017 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-27 20:37 UTC by Mark A. Hershberger
Modified: 2014-09-30 23:00 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark A. Hershberger 2014-01-27 20:37:44 UTC
That is, when update.php is needed to add contenthandler fields.

Commenting out the following line allows update.php to run to completion:

  $wgExtensionFunctions[] = array( 'ExtDynamicPageList', 'setupDPL' );

It would be better to have the exists() skipped if it is going to cause problems.
Comment 1 Mark A. Hershberger 2014-01-27 20:41:15 UTC
error with backtrace:

A database query error has occurred.
Query: SELECT  page_id,page_len,page_is_redirect,page_latest,page_content_model  FROM `page`   WHERE page_namespace = '10' AND page_title = 'Extension_DPL'  LIMIT 1
Function: LinkCache::addLinkObj
Error: 1054 Unknown column 'page_content_model' in 'field list' (localhost)

Backtrace:
 #0 includes/db/Database.php(1039): DatabaseBase->reportQueryError('Unknown column ...', 1054, 'SELECT  page_id...', 'LinkCache::addL...', false)
 #1 includes/db/Database.php(1496): DatabaseBase->query('SELECT  page_id...', 'LinkCache::addL...')
 #2 includes/db/Database.php(1585): DatabaseBase->select('page', Array, Array, 'LinkCache::addL...', Array, Array)
 #3 includes/cache/LinkCache.php(272): DatabaseBase->selectRow('page', Array, Array, 'LinkCache::addL...', Array)
 #4 includes/Title.php(2994): LinkCache->addLinkObj(Object(Title))
 #5 includes/Title.php(4450): Title->getArticleID()
 #6 extensions/DynamicPageList/DPLSetup.php(1234): Title->exists()
 #7 extensions/DynamicPageList/DPLSetup.php(1211): ExtDynamicPageList::commonSetup()
 #8 [internal function]: ExtDynamicPageList::setupDPL()
 #9 includes/Setup.php(592): call_user_func(Array)
 #10 maintenance/doMaintenance.php(106): require_once('/vagrant/mediaw...')
 #11 maintenance/update.php(187): require_once('/vagrant/mediaw...')
 #12 {main}
Comment 2 Mark A. Hershberger 2014-09-11 01:31:39 UTC
Dad gum. Ran into this again, thought I had had dealt with it in the past, found a fix and came here to file a bug so I could submit a patch.  Found this already filed bug.

Whee!

Patch incoming.
Comment 3 Gerrit Notification Bot 2014-09-11 02:08:40 UTC
Change 159658 had a related patch set uploaded by MarkAHershberger:
Don't check for Template:Extension_DPL during update

https://gerrit.wikimedia.org/r/159658
Comment 4 Gerrit Notification Bot 2014-09-17 20:32:58 UTC
Change 159658 merged by jenkins-bot:
Don't check for Template:Extension_DPL during update

https://gerrit.wikimedia.org/r/159658
Comment 5 Bawolff (Brian Wolff) 2014-09-19 02:56:22 UTC
*** Bug 71017 has been marked as a duplicate of this bug. ***
Comment 6 Gerrit Notification Bot 2014-09-19 02:59:35 UTC
Change 161415 had a related patch set uploaded by Brian Wolff:
Don't check for Template:Extension_DPL during update

https://gerrit.wikimedia.org/r/161415
Comment 7 Gerrit Notification Bot 2014-09-19 03:11:13 UTC
Change 161416 had a related patch set uploaded by Brian Wolff:
Don't check for Template:Extension_DPL during update

https://gerrit.wikimedia.org/r/161416
Comment 8 Gerrit Notification Bot 2014-09-19 03:11:56 UTC
Change 161416 merged by jenkins-bot:
Don't check for Template:Extension_DPL during update

https://gerrit.wikimedia.org/r/161416
Comment 9 Gerrit Notification Bot 2014-09-19 03:12:17 UTC
Change 161415 merged by jenkins-bot:
Don't check for Template:Extension_DPL during update

https://gerrit.wikimedia.org/r/161415
Comment 10 Bawolff (Brian Wolff) 2014-09-19 03:15:59 UTC
This fix is now backported to REL1_23 and REL1_22 branches, so if you're using the version of this extension for MediaWiki 1.22 or higher, it should be fixed.
Comment 11 Mark A. Hershberger 2014-09-30 22:31:28 UTC
Apparently not fixed.  I am re-running an update with a complete n00b and this came up again even with the patch applied.

Verifying before I do anything else here.
Comment 12 Mark A. Hershberger 2014-09-30 23:00:14 UTC
See bug #57335 comment #5

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links