Last modified: 2014-11-01 03:00:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62497, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60497 - VisualEditor: Diff styling in save dialog is broken
VisualEditor: Diff styling in save dialog is broken
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
: 57300 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-27 21:44 UTC by Roan Kattouw
Modified: 2014-11-01 03:00 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot of the bug (9.07 KB, image/png)
2014-01-27 21:44 UTC, Roan Kattouw 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-01-27 21:44:54 UTC 
Created attachment 14385 [details]
Screenshot of the bug

The diff in the save dialog isn't being styled correctly, which causes highlighted text to overlap with text above it. Timo tells me that this is due to a missing line-height style.

This is exacerbated by bug 60494. which causes the save dialog to be narrower than it should be, which means lines wrap more often and highlighted text more frequently has text directly above it.
Comment 1 Alex Monk 2014-05-14 01:08:49 UTC 
So I think we just need to apply line-height: 1.6px to the body of the frame like MW core does for #bodyContent, .mw-body-content (but I don't think we should use those here as they apply some other changes which don't look right e.g. font-size: 0.875em)
Comment 2 James Forrester 2014-06-30 22:53:31 UTC 
This has been fixed, AFAICT.
Comment 3 Alex Monk 2014-11-01 03:00:03 UTC 
*** Bug 57300 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links