Last modified: 2014-02-04 04:15:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62502, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60502 - VisualEditor: Trying to open gallery inspector when an image or reference is selected causes JS error
VisualEditor: Trying to open gallery inspector when an image or reference is ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Highest normal
: VE-deploy-2014-01-30
Assigned To: Roan Kattouw
:
: 60699 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-27 22:33 UTC by Rummana Yasmeen
Modified: 2014-02-04 04:15 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (348.97 KB, image/png)
2014-01-27 22:37 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-01-27 22:33:27 UTC 
Steps to reproduce:

1.Open a page with VE
2.Select an image
3.Go to Insert>Gallery

Observed Result:
An error appears in the console "Uncaught TypeError: Cannot read property 'body' of undefined"

After that the Media Settings option does not appear on any other image .Also the reference dialog option does not show up when you select a reference note.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Comment 1 Rummana Yasmeen 2014-01-27 22:37:18 UTC 
Created attachment 14386 [details]
Screenshot
Comment 2 Roan Kattouw 2014-01-27 22:44:14 UTC 
There's no validation going on in MWExtensionInspector at all, so it's happy to try and inspect references or images or anything that's inspectable, even if it can't be inspected by the inspector you tried to open.
Comment 3 Gerrit Notification Bot 2014-01-28 03:23:35 UTC 
Change 109832 had a related patch set uploaded by Catrope:
Don't throw JS errors when opening MWExtensionInspector on the wrong node type

https://gerrit.wikimedia.org/r/109832
Comment 4 Gerrit Notification Bot 2014-01-28 19:12:38 UTC 
Change 109832 merged by jenkins-bot:
Don't throw JS errors when opening MWExtensionInspector on the wrong node type

https://gerrit.wikimedia.org/r/109832
Comment 5 Rummana Yasmeen 2014-01-29 18:47:59 UTC 
Verified the fix in Betalabs:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=29th_January&veaction=edit
Comment 6 Rummana Yasmeen 2014-01-30 23:16:19 UTC 
Verified the fix in test2 and mw.org
Comment 7 Rummana Yasmeen 2014-01-31 21:49:43 UTC 
*** Bug 60699 has been marked as a duplicate of this bug. ***
Comment 8 Gerrit Notification Bot 2014-01-31 23:10:57 UTC 
Change 110652 had a related patch set uploaded by Jforrester:
Don't throw JS errors when opening MWExtensionInspector on the wrong node type

https://gerrit.wikimedia.org/r/110652
Comment 9 Gerrit Notification Bot 2014-02-03 23:37:22 UTC 
Change 110652 merged by jenkins-bot:
Don't throw JS errors when opening MWExtensionInspector on the wrong node type

https://gerrit.wikimedia.org/r/110652
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links