Last modified: 2014-05-02 00:20:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62517, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60517 - Update to pegjs 0.8
Update to pegjs 0.8
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
tokenizer (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Arlo Breault
: performance
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-28 02:19 UTC by Gabriel Wicke
Modified: 2014-05-02 00:20 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2014-01-28 02:19:25 UTC 
0.8 promises better performance, besides a bunch of other improvements:

https://github.com/gwicke/pegjs/blob/master/CHANGELOG.md

At a minimum, we'll need to change all references to pos and pos0 to peg$pos etc, and also rework the cache key patch regexp in mediawiki.tokenizer.peg.js. 

Also relevant:

"Removed the toSource method of generated parsers and introduced a new output option of the PEG.buildParser method. It allows callers to specify whether they want to get back the parser object or its source code."
Comment 1 Gabriel Wicke 2014-02-03 20:20:42 UTC 
Rather than using peg$pos we should probably use the public offset() methods now available in 0.8.
Comment 2 Gabriel Wicke 2014-04-30 03:46:18 UTC 
The current tokenizer (0.6) is responsible for 24% of our cpu time when parsing [[en:Barack Obama]], so there is a good amount of potential here.
Comment 3 Gerrit Notification Bot 2014-04-30 04:45:01 UTC 
Change 130561 had a related patch set uploaded by Arlolra:
WIP: Upgrade to pegjs v0.8

https://gerrit.wikimedia.org/r/130561
Comment 4 Gerrit Notification Bot 2014-05-02 00:15:48 UTC 
Change 130561 merged by GWicke:
Upgrade to pegjs v0.8

https://gerrit.wikimedia.org/r/130561
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links