Last modified: 2014-06-20 17:41:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62561, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60561 - Don't always disable caching when special pages are transcluded
Don't always disable caching when special pages are transcluded
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.23.0
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-29 03:06 UTC by Jackmcbarn
Modified: 2014-06-20 17:41 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jackmcbarn 2014-01-29 03:06:09 UTC
Currently, pages that transclude special pages aren't cached at all. I see the benefit to this (that special pages should always be "live"), but at the same time, we can probably find a smarter way of handling caching that doesn't need to completely disable it. This will likely become a bigger issue as more and more special pages are given the ability to be transcluded.
Comment 1 Bawolff (Brian Wolff) 2014-01-29 03:18:58 UTC
(In reply to comment #0)
> Currently, pages that transclude special pages aren't cached at all. I see
> the
> benefit to this (that special pages should always be "live"), but at the same
> time, we can probably find a smarter way of handling caching that doesn't
> need
> to completely disable it. This will likely become a bigger issue as more and
> more special pages are given the ability to be transcluded.

I've been thinking it would be good to have a method of the SpecialPage class, getTranscludeCacheTime(), which by default returns 0 (Or perhaps it should return 1 hour or something small. On a busy page, even a very small cache time would probably make a huge performance difference), which people could override as appropriate.

I would also suggest that the RequestContext passed to the special page for any special page which doesn't disable cache, doesn't include the current user/etc, but instead includes an anonoymous user, and the page rendering language for the language. That way we won't have user specific things poisioning the cahe (For example, {{special:Recentchanges}} will currently show block links if you have block rights. This would be bad if the page was uncached)
Comment 2 Gerrit Notification Bot 2014-06-20 17:41:06 UTC
Change 140945 had a related patch set uploaded by Jackmcbarn:
Make transcluded special pages not disable cache in miser mode.

https://gerrit.wikimedia.org/r/140945

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links