Last modified: 2014-03-01 00:12:40 UTC
Created attachment 14411 [details] Screenshot attached Steps to reproduce: 1.Open a page with VE 2.Add any image 3.Go to Media Settings>Advanced Settings 4.Say for example the original dimension of the image is 150x150 5.Change the values in such way that it exceeds the original size for example: 300x300 Observed Result: Apply Changes button remains active even though "Size values are invalid " appears in the dialog box. See the screenshot attached. Test Environment: http://en.wikipedia.beta.wmflabs.org/ Browser: Chrome Version 26.0.1410.65 OS: MAC OS X 10. 8. 5 Sample Page:http://en.wikipedia.beta.wmflabs.org/wiki/29th_January?veaction=edit
This is actually intended behavior, but one that's not clearly explained; if the size parameters are invalid, the media edit dialog will apply all other changes except for size (so to allow other changes like image type, alternate text, etc) There are two ways to solve this bug imho: 1. Adjust the message to "Size values are invalid and will not be applied." 2. Make the 'apply' button inactive if size is invalid, forcing the user to find valid parameters or cancel -- but this will also mean that if other changes were made in the dialog, and the user doesn't know or want to change the size after seeing it is invalid (or wants to revert to the previous dimensions) we force them to cancel *all* changes and redo them again. I am leaning towards #1, but we should discuss and see if we want to apply #2.
> I am leaning towards #1, but we should discuss and see if we want to apply > #2. Wont #2 be more obvious ?
The problem in my opinion with #2 is that if a user spent time working on new settings (caption / alternate text / position etc) we force them to deal with size before applying the rest. In general I think that might be less convenient in the long run. I think the better approach (giving the user more leeway) is to alert the user that the parameter is wrong and won't be applied, save everything else, and allow the user to go back in and deal with the size widget specifically if they want to (or decide they don't want to deal with numerical values and resize with the mouse) I think that while it's less like "others" are doing, this might give the user more leeway when fixing and working on stuff. Instead of forcing the user to deal with a problem they might just want to undo, we let the user save everything else and choose if they want to go back to retrying the size specifically.
I think this can be best "fixed" by altering the design and copy so that it's clear that invalid changes won't be put into effect.
