Last modified: 2014-01-31 21:43:33 UTC
Created attachment 14412 [details] screenshot The "Create another account" link is a weird Frankenstein element that is a link inside an h3 inside a div that is assigned the mw-ui-button class to make it appear as a button. This causes all sorts of conflicting CSS to be assigned to it. For example, on mobile all h3s are displayed in serif font. (See screenshot.) The h3 tag should be removed, as both the div and the link already have unique IDs available to increase the font-size (mw-createaccount-another and mw-createaccount-join).
Change 110296 had a related patch set uploaded by Kaldari: Remove unneeded h3s around Create Account links https://gerrit.wikimedia.org/r/110296
Change 110296 merged by jenkins-bot: Remove unneeded h3s around Create Account links https://gerrit.wikimedia.org/r/110296
Compare: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:UserLogin&returnto=Main+Page to mediawiki.org and enwiki prod. Removing the h3 here and turning it in to a div created an unwanted line break, if you look at this on Beta Labs. In English (other languages may be too long) it is short enough to be on one line. Unless the button text or description are too long (as in some langauges) we should not have a line break between them. Please test and fix this before this goes out to enwiki.
That's because width of the container is defined to be 20em, and the size of 'em' changed. We should not depend on it not to change for pixel-perfect sizing, and we should not build pixel-perfect layouts for one language only… This is fixed, please feel free to submit a patch to fix the silly em sizing. It was there before and I don't believe the change is layout to be a bug, really, it's just different.
(In reply to comment #4) > That's because width of the container is defined to be 20em, and the size of > 'em' changed. We should not depend on it not to change for pixel-perfect > sizing, and we should not build pixel-perfect layouts for one language only… > > This is fixed, please feel free to submit a patch to fix the silly em sizing. > It was there before and I don't believe the change is layout to be a bug, > really, it's just different. Wrong. You can't break a design with a patch and then call it fixed.
