Last modified: 2014-02-06 15:19:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62633, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60633 - Fatal error: Call to a member function getId() on a non-object in CourseTalkNotification.php on line 108
Fatal error: Call to a member function getId() on a non-object in CourseTalk...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
EducationProgram (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Andrew Green
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-30 19:10 UTC by Sam Reed (reedy)
Modified: 2014-02-06 15:19 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2014-01-30 19:10:32 UTC
[30-Jan-2014 19:06:49] Fatal error: Call to a member function getId() on a non-object at /usr/local/apache/common-local/php-1.23wmf11/extensions/EducationProgram/includes/notifications/CourseTalkNotification.php on line 108
Server: mw1173
Method: POST
URL: http://en.wikipedia.org/w/index.php?title=Education_Program_talk:University_of_California,_Berkeley/Cyberlaw_(Spring_2014)/Timeline&action=submit
Backtrace:
#0 /usr/local/apache/common-local/php-1.23wmf11/extensions/EducationProgram/includes/notifications/CourseTalkNotification.php(108): EducationProgram\CourseTalkNotification::trigger()
#1 /usr/local/apache/common-local/php-1.23wmf11/extensions/EducationProgram/includes/notifications/NotificationsManager.php(158): EducationProgram\CourseTalkNotification->trigger(Array)
#2 /usr/local/apache/common-local/php-1.23wmf11/extensions/EducationProgram/EducationProgram.hooks.php(590): EducationProgram\NotificationsManager->trigger('ep-course-talk-...', Array)
#3 [internal function]: EducationProgram\Hooks::onPageContentSaveComplete(Object(WikiPage), Object(User), Object(WikitextContent), '+sign ups', 0, NULL, NULL, 98, NULL, Object(Status), false)
#4 /usr/local/apache/common-local/php-1.23wmf11/includes/Hooks.php(206): call_user_func_array('EducationProgra...', Array)
#5 /usr/local/apache/common-local/php-1.23wmf11/includes/GlobalFunctions.php(4034): Hooks::run('PageContentSave...', Array, NULL)
#6 /usr/local/apache/common-local/php-1.23wmf11/includes/WikiPage.php(1975): wfRunHooks('PageContentSave...', Array)
#7 [internal function]: WikiPage->doEditContent(Object(WikitextContent), '+sign ups', 98, false, NULL, 'text/x-wiki')
#8 /usr/local/apache/common-local/php-1.23wmf11/includes/Article.php(2047): call_user_func_array(Array, Array)
#9 /usr/local/apache/common-local/php-1.23wmf11/includes/EditPage.php(1806): Article->__call('doEditContent', Array)
#10 /usr/local/apache/common-local/php-1.23wmf11/includes/EditPage.php(1806): Article->doEditContent(Object(WikitextContent), '+sign ups', 98, false, NULL, 'text/x-wiki')
#11 /usr/local/apache/common-local/php-1.23wmf11/includes/EditPage.php(1231): EditPage->internalAttemptSave(Array, false)
#12 /usr/local/apache/common-local/php-1.23wmf11/includes/EditPage.php(428): EditPage->attemptSave()
#13 /usr/local/apache/common-local/php-1.23wmf11/includes/actions/EditAction.php(50): EditPage->edit()
#14 /usr/local/apache/common-local/php-1.23wmf11/includes/actions/EditAction.php(74): EditAction->show()
#15 /usr/local/apache/common-local/php-1.23wmf11/includes/Wiki.php(441): SubmitAction->show()
#16 /usr/local/apache/common-local/php-1.23wmf11/includes/Wiki.php(305): MediaWiki->performAction(Object(Article), Object(Title))
#17 /usr/local/apache/common-local/php-1.23wmf11/includes/Wiki.php(599): MediaWiki->performRequest()
#18 /usr/local/apache/common-local/php-1.23wmf11/includes/Wiki.php(460): MediaWiki->main()
#19 /usr/local/apache/common-local/php-1.23wmf11/index.php(49): MediaWiki->run()
#20 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#21 {main}
Comment 1 Sam Reed (reedy) 2014-01-30 19:46:05 UTC
	public function trigger( $params ) {

		$revision = $params['revision'];

		\EchoEvent::create( array(
			'type' => CourseTalkNotification::KEY,
			'title' => $params['course-talk-title'],
			'agent' => $params['agent'],
			'extra' => array (

				// 'revid' is used by the EchoBasicFormatter (which
				// CourseTalkFormatter inherits from) to generate the diff
				// destination, which we use in the secondary link.
				'revid' => $revision->getId(),
			),
		) );
	}



Not checking if there's actually a revision object...
Comment 2 Andrew Green 2014-01-31 03:15:35 UTC
https://gerrit.wikimedia.org/r/#/c/110446/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links