Last modified: 2014-09-02 23:10:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62661, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60661 - Mediawiki.ui buttons: active state is slightly bigger than disabled state due to border
Mediawiki.ui buttons: active state is slightly bigger than disabled state due...
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-31 01:24 UTC by Maryana Pinchuk
Modified: 2014-09-02 23:10 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Different heights of .mw-ui-button.mw-ui-primary and .mw-ui-button (4.38 KB, image/png)
2014-02-15 15:09 UTC, Sergey Leschina
Details
Plain mw-ui-button (1.41 KB, image/png)
2014-02-19 02:03 UTC, Matthew Flaschen
Details

Description Maryana Pinchuk 2014-01-31 01:24:59 UTC
Try replying to any Flow post - e.g., this one: https://www.mediawiki.org/w/index.php?title=Talk:Sandbox&topic%5BpostId%5D=050f698e3f6e5624fa1590b11c27932f&workflow=050f698e3f6e5624fa1590b11c27932f

Before you start typing, when the button is not active, it's smaller than when you start typing and it becomes active – apparently due to a border that appears in the active state. In context, this causes the rest of the buttons in that row to jump a bit and generally looks a bit janky.
Comment 1 Sergey Leschina 2014-02-15 15:09:44 UTC
Created attachment 14601 [details]
Different heights of .mw-ui-button.mw-ui-primary and .mw-ui-button

Same problem with button which hasn't any additional styles, just .mw-ui-button.
Comment 2 Matthew Flaschen 2014-02-19 02:02:58 UTC
(In reply to Sergey Leschina from comment #1)
> Created attachment 14601 [details]
> Different heights of .mw-ui-button.mw-ui-primary and .mw-ui-button
> 
> Same problem with button which hasn't any additional styles, just
> .mw-ui-button.

Which wiki are you testing that on, and with what page?  That is not the current styling for a plain mediawiki.ui.button (it's a little too dark, for one thing).  Plain buttons now look like the attached.

More generally, this needs to be retested after Flow removes the custom overrides for core classes.  It may be a problem with the Flow code, rather than core.
Comment 3 Matthew Flaschen 2014-02-19 02:03:52 UTC
Created attachment 14625 [details]
Plain mw-ui-button

A plain mw-ui-button to demonstrate core styling
Comment 4 spage 2014-03-06 00:15:06 UTC
Comment #0 doesn't apply to the mediawiki.ui in core, since a disabled button has a gray background.

But comment #1 does apply to mediawiki.ui in core, neutral buttons are still bigger than the colored buttons, due to different border handling. I filed bug 62292 before noticing this one.
Comment 5 Jon 2014-09-02 23:10:47 UTC
I don't think this bug is relevant anymore?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links