Last modified: 2014-02-04 04:08:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62662, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60662 - VisualEditor: VE doesn't load on mobile anymore
VisualEditor: VE doesn't load on mobile anymore
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Mobile (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-01-30
Assigned To: Juliusz Gonera
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-31 01:53 UTC by Jon
Modified: 2014-02-04 04:08 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2014-01-31 01:53:40 UTC
http://en.m.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Ronin?mobileaction=alpha#editor/0

Error: Container must be attached to the DOM Error {stack: (...), message: "Container must be attached to the DOM"}
Comment 1 Roan Kattouw 2014-01-31 02:06:28 UTC
This is exposing a pre-existing bug in mobile VE or MobileFrontend's VE integration or something in this ecosystem: you cannot initialize targets into a container that isn't already attached to the DOM. Previously, you could do this and various things regarding measurements would just break and render wrong, but now we throw an exception.
Comment 2 Krinkle 2014-01-31 02:07:05 UTC
@Juliusz: Looks like the .surface element selector here is either not finding anything at all or it is referring to something that is still detached at that point:

https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/c4264d76bc817df71c6b3631afb19be737246c52/javascripts/modules/editor/VisualEditorOverlay.js#L16

It doesn't have to be fully initialised, but the target container element should however be somewhere in the document.
Comment 3 Gerrit Notification Bot 2014-01-31 02:31:05 UTC
Change 110498 had a related patch set uploaded by JGonera:
Fix VE error with latest VE master

https://gerrit.wikimedia.org/r/110498
Comment 4 Gerrit Notification Bot 2014-01-31 17:59:22 UTC
Change 110498 merged by jenkins-bot:
Fix VE error with latest VE master

https://gerrit.wikimedia.org/r/110498

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links