Last modified: 2014-02-19 22:19:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62663, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60663 - Flow: post permalink URLs added a topic[postId] parameter
Flow: post permalink URLs added a topic[postId] parameter
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-31 03:11 UTC by spage
Modified: 2014-02-19 22:19 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-01-31 03:11:16 UTC
A permalink on the old code on ee-flow-big instance is

http://ee-flow-big.instance-proxy.wmflabs.org/w/index.php?
title=Talk:Sandbox&
workflow=050b263a41bd4ba5b8c6fa163e1846b9
#flow-post-050f9884ce0ee46a90ebfa163e1846b9

i.e. just the topic and with a fragment to scroll the post into view (and highlight with JS).

By 1.23wmf13 a permalink becomes

https://www.mediawiki.org/w/index.php?
title=Talk:Sandbox&
topic[postId]=050f56f284d4d0411a91842b2b774fd8&
workflow=050f142239ecc14b3c5090b11c2789df
#flow-post-050f56f284d4d0411a91842b2b774fd8

The topic[postId] isn't currently required, is it there for future-proofing? e.g. if we paginate topics or split posts.
Comment 1 Quiddity 2014-01-31 23:53:21 UTC
Related to bug 60638 I think.
Comment 2 Helder 2014-02-04 11:52:24 UTC
Moreover, the "topic[postId]" breaks the links, as reported on
https://www.mediawiki.org/wiki/Thread:Extension_talk:Scribunto/Framework_for_interactive_applications_on-wiki/reply_%282%29

Are the user supposed to know that they need to replace "topic[postId]" by "%5BpostId%5D"?
(I used encodeURIComponent('[postId]') in the console to get this)

Should this encoding problem be reported in a new bug?
Comment 3 Quiddity 2014-02-04 18:30:37 UTC
(In reply to comment #2)
> Should this encoding problem be reported in a new bug?

Nope, that's already bug 56196 (patch to review). Thanks though :)
Comment 4 Maryana Pinchuk 2014-02-06 22:04:12 UTC
Splitting off posts is definitely something we want to do in the future, and we probably do need to keep paginating topics on standby as a possible feature - can't intelligently comment on the rest of the bug, but those are two potential product needs, yes :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links