Last modified: 2014-02-04 17:13:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62670, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60670 - JS errors on SomeValueSnak/NoValueSnak
JS errors on SomeValueSnak/NoValueSnak
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest critical with 1 vote (vote)
: ---
Assigned To: Adrian Lang
UI
: javascript
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-31 09:24 UTC by Daniel Kinzler
Modified: 2014-02-04 17:13 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2014-01-31 09:24:08 UTC 
Some code seems to assume all Snaks have the getValue() and getType() methods, but SomeValueSnak and NoValueSnak don't. This triggeres JS errors, causing the page to be only partially initialized:

When loading Q38 on wikidata.org with FF 26.0 (logged in), I get:
TypeError: snak.getValue is not a function

In chromium, I get:
TypeError: Object #<WbPropertyNoValueSnak> has no method 'getValue'
Comment 1 Daniel Kinzler 2014-01-31 09:26:21 UTC 
When fixing this, please add a regression test. We should be testing all data types with SomeValue/NoValue snaks.
Comment 2 Lydia Pintscher 2014-01-31 10:05:04 UTC 
Hoo was working on that I think.
Comment 3 Marius Hoch 2014-01-31 10:09:39 UTC 
(In reply to comment #2)
> Hoo was working on that I think.

This is fixed, but not sure why it's not deployed, will investigate.
Comment 4 Adrian Lang 2014-01-31 10:24:22 UTC 
I found another instance of this issue, see https://gerrit.wikimedia.org/r/110527/. Still need the tests, though.
Comment 5 Marius Hoch 2014-01-31 13:09:04 UTC 
Tests are a different thing, this stills waits for a deploy
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links