Last modified: 2014-02-06 22:07:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62673, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60673 - Flow: update browser tests for UI changes
Flow: update browser tests for UI changes
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://wmf.ci.cloudbees.com/view/r-f...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-31 11:14 UTC by spage
Modified: 2014-02-06 22:07 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-01-31 11:14:29 UTC
The edit menu moved to the action menu. I think as a result three tests fail:

1. Edit existing title.Edit an existing title

I think this fails because the test has to activate the Actions menu to see "Edit title"


2. Edit existing title.Edit existing post

This failure is
timed out after 5 seconds, waiting for {:title=>"Edit post", :index=>0, :tag_name=>"a"} to
The edit icon had "Edit post" as its title attribute, but the new ultra-quiet Edit button has only title="Edit". The fix here is just to update the flow_page object element for edit_post_icon, and clean up the naming of this and "Edit post pencil icon" now it's no longer an icon.


3. Create new topic anonymous.Anon does not see block or actions

The latter failure is
expected #<Watir::Anchor:0x50d5ea2bc230a85c located=true selector={:text=>"Actions", :index=>1, :tag_name=>"a"}> not to exist (RSpec::Expectations::ExpectationNotMetError)

An anonymous user doesn't get hide/delete/suppress actions, so before this change would not get an action menu.  But now I think the Actions indicator is present, because s/he can edit a post if s/he created it.
Comment 1 Gerrit Notification Bot 2014-01-31 18:08:30 UTC
Change 110597 had a related patch set uploaded by Spage:
Fix browser tests for new topic UI

https://gerrit.wikimedia.org/r/110597
Comment 2 Chris McMahon 2014-02-06 22:07:38 UTC
I fixed this yesterday and it is passing on beta labs right now

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links