Last modified: 2014-02-05 21:28:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62694, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60694 - Content of different article is showing up in the Edit mode of VE in Betalabs; Parsoid does not find its config and uses default settings instead
Content of different article is showing up in the Edit mode of VE in Betalabs...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-31 20:36 UTC by Rummana Yasmeen
Modified: 2014-02-05 21:28 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (175.32 KB, image/png)
2014-01-31 20:36 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-01-31 20:36:22 UTC
Created attachment 14429 [details]
Screenshot

Steps to reproduce:


1.Create a page on Betalabs
2.Add some content and save it
3.Reopen the page with VE

Observed Result:
Content of some article is showing up instead of my own edited content


See the screenshot attached


Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/31st_january
Comment 1 Rummana Yasmeen 2014-01-31 21:25:40 UTC
Now, Uncaught TypeError: Cannot read property 'status' of null is appearing while trying to open VE in betalabs
Comment 2 Jeff Hall 2014-01-31 23:27:20 UTC
I've also been seeing this behavior in beta labs today, although it's been difficult to consistently reproduce.  I've seen it much more frequently with the automated browser tests than I have with manual testing.
Comment 3 Ryan Kaldari 2014-02-03 19:27:20 UTC
I noticed this today at
http://en.m.wikipedia.beta.wmflabs.org/wiki/0.07511468210381089

Whenever I load VisualEditor, it loads the allergy article instead.
Comment 4 ssastry 2014-02-03 19:29:31 UTC
Does beta.wmflabs.org have latest parsoid master? Related is bug 60372 which was fixed in https://gerrit.wikimedia.org/r/#/c/110233/
Comment 5 Ryan Kaldari 2014-02-03 19:33:15 UTC
It seems to be quite easy to consistently reproduce. Just click 'random article' and then load the VisualEditor. I get the contents of a different article 100% of the time. The really weird thing is that the articles that are being loaded don't seem to even exist on Beta Labs.
Comment 6 Gabriel Wicke 2014-02-03 19:45:57 UTC
This is unlikely to be related to bug 60372, as a) the oldid is sent, and b) it only happened sometimes under high request loads.

This does not happen in production (running Parsoid master right now). I'm suspecting a configuration issue in betalabs.
Comment 7 Gabriel Wicke 2014-02-03 21:54:03 UTC
Note that this could also be VE sending the wrong oldid, as that will always take precedence over the page name.
Comment 8 Gabriel Wicke 2014-02-03 22:03:14 UTC
A bit more investigation shows that VE is sending the right oldid.

I think this is caused by Parsoid not finding its config file in the deploy repo. In the production upstart config we are now passing the explicit path to a config file to parsoid, which is checked into conf/wmf/localsettings.js in the deploy repo. Beta labs might still rely on localsettings.js being in src/api, which will no longer work.

I think we'll need to make the config path configurable in the upstart file, and set a different path (ideally conf/wmf-beta or the like) for betalabs.
Comment 9 Antoine "hashar" Musso (WMF) 2014-02-03 22:41:11 UTC
On deployment-parsoid2 in /var/log/parsoid/parsoid.log

{ [Error: Cannot find module '/srv/deployment/parsoid/conf/wmf/localsettings.js'] code: 'MODULE_NOT_FOUND' }

There is no conf directory but there is a file /srv/deployment/parsoid/localsettings.js which is described in puppet:

 manifests/role/parsoid.pp:    file { '/srv/deployment/parsoid/localsettings.js':

I introduced it on Jan 2 with https://gerrit.wikimedia.org/r/#/c/104938/


The upstart configuration I wrote ( /etc/init/parsoid.conf ) was pointing to it but now points to ../conf/wmf/localsettings.js.

So I guess the easiest path is to use an env variable such as PARSOID_CONF, set it in /etc/default/parsoid and make it vary in the puppet configuration.
Comment 10 spage 2014-02-04 01:55:48 UTC
Another symptom of this is if you add or edit a post to a Flow board on betalabs (e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA ) and transclude a page with {{:Article name }}, it pulls in the page from enwiki.
Comment 11 Gabriel Wicke 2014-02-04 03:46:45 UTC
https://gerrit.wikimedia.org/r/#/c/110666/ creates a Debian package and makes the config file path configurable in /etc/defaults/mediawiki-parsoid. We might still want to fix this in puppet temporarily until we move to deb-based installs.
Comment 12 Chris McMahon 2014-02-04 20:35:02 UTC
We need this on beta labs at the earliest opportunity.  I raised the importance.
Comment 13 Gerrit Notification Bot 2014-02-04 22:32:55 UTC
Change 111350 had a related patch set uploaded by GWicke:
Bug 60694: Make the config file path configurable

https://gerrit.wikimedia.org/r/111350
Comment 14 Gerrit Notification Bot 2014-02-05 18:32:56 UTC
Change 111350 merged by Alexandros Kosiaris:
Bug 60694: Make the config file path configurable

https://gerrit.wikimedia.org/r/111350
Comment 15 Gabriel Wicke 2014-02-05 19:45:37 UTC
The puppet agent didn't seem to be running on the parsoid host in beta labs, and after starting that Parsoid was not restarted to reflect the the changes. Fixed that manually, and verified fixed at http://en.wikipedia.beta.wmflabs.org/wiki/0.6884344289426402?veaction=edit.
Comment 16 Rummana Yasmeen 2014-02-05 21:28:20 UTC
Verified the fix on Betalabs.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links