Last modified: 2014-09-22 09:43:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62695, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60695 - {{SITENAME}} not parsed: "Publish to {{SITENAME}}" as message box title when $wgDefaultUserOptions['wikieditor-publish'] = 1
{{SITENAME}} not parsed: "Publish to {{SITENAME}}" as message box title when ...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
master
All All
: Low normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-31 21:02 UTC by T. Gries
Modified: 2014-09-22 09:43 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2014-01-31 21:02:16 UTC
I am referring to latest core and latest E:WikiEditor version from git.

When you have set

- # Displays the Publish and Cancel buttons on the top right side
- $wgDefaultUserOptions['wikieditor-publish'] = 1;

and when you click on "publish" (these button are _only_ shown, when the option $wgDefaultUserOptions['wikieditor-publish'] is set to 1 as shown above -

then the TitleMsg of the Javascript-generated box is 

"Publish to {{SITENAME}}"

because {{SITENAME}} is not rendered!


The message key in https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikiEditor/4433c7b98a0959fedbf1fce4b798a24b27d85001/WikiEditor.i18n.php#L33 is

'wikieditor-publish-dialog-title' => 'Publish to {{SITENAME}}',

and the modules does not render this correctly, the message text being therefore wrong for all translated languages.

Suggestion:

Fix the module https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikiEditor/4433c7b98a0959fedbf1fce4b798a24b27d85001/modules%2Fjquery.wikiEditor.publish.js
Comment 1 Derk-Jan Hartman 2014-04-10 09:24:00 UTC
Fixing this, currently conflicts with Bug: 42107 and https://gerrit.wikimedia.org/r/#/c/82092/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links