Last modified: 2014-02-11 13:49:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62700, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60700 - mw-createaccount-cta needs to be one line
mw-createaccount-cta needs to be one line
Status: NEW
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Ryan Kaldari
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-31 21:48 UTC by Steven Walling
Modified: 2014-02-11 13:49 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Steven Walling 2014-01-31 21:48:00 UTC
The change that resulted from bug 60605 caused an undesirable link break between the button and the text in the mw-createaccount-cta div. 

These two elements were designed to be on the same line wherever possible. Having a new line for each element is unnecessary and distracting.
Comment 1 Bartosz Dziewoński 2014-01-31 21:48:38 UTC
Does it? It's not in most languages.
Comment 2 Steven Walling 2014-01-31 21:59:27 UTC
(In reply to comment #1)
> Does it? It's not in most languages.

It is ideally supposed to be one line, but we can't control the length of a translation. en, pl, zh, and others have one line. Other languages (es, pt, ja, fr, de etc.) have two because of the string length. 

We can't accommodate all the lengthy translations because you don't want a CTA below a form to be wider than the form itself. If we absolutely want to enforce no line break in the cta, then the proper resolution is to resolve bug 47392 by moving the cta to the right of the form and remove mw-ui-vform's restriction of width: 290px;. That is okay with me, but in the interim it should not be that hard to prevent an unnecessary line break if the text is short enough.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links