Last modified: 2014-03-01 00:13:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62705, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60705 - VisualEditor: Providing clearer errors about invalid media item sizes on new Media Settings>Advanced Settings
VisualEditor: Providing clearer errors about invalid media item sizes on new ...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-01 00:57 UTC by Rummana Yasmeen
Modified: 2014-03-01 00:13 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rummana Yasmeen 2014-02-01 00:57:38 UTC
Right now, if I add an image for example:https://test2.wikipedia.org/wiki/File:Foo.jpg

Initially in VE from Insert>Media it renders as 229x150.
If a user attempts to resize it to 350x350 , it will show a message that "Size Values are invalid"  as it has exceeded the original dimension values.But unless user knows those original dimensions , he or she might keep trying with different values not knowing what should be the input limit.

I think it will be better if we can have more clearer indication in the message saying something like "the size values are invalid since it has exceeded original dimension"
Comment 1 James Forrester 2014-02-06 04:34:25 UTC
We should probably have several errors:

* "Size can be up to <width>x<height> pixels." (if too big for media)
* "Size must be positive whole numbers." (if not valid, e.g. negative or "hello")
* "Size is limited to <maxsize> pixels." (if SVGMaxSize reached)
Comment 2 Moriel Schottlender 2014-02-06 04:58:34 UTC
Should those block the 'apply' button, or just give an indication that the size itself won't be applied, giving the user the option to apply the rest of the properties?
Comment 3 James Forrester 2014-02-06 05:11:56 UTC
(In reply to comment #2)
> Should those block the 'apply' button, or just give an indication that the
> size itself won't be applied, giving the user the option to apply the rest
> of the properties?

The second – see bug 60602.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links