Last modified: 2014-02-04 17:13:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62715, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60715 - Wikidata interface stored in cache using wrong language code
Wikidata interface stored in cache using wrong language code
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest major (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-01 09:37 UTC by John Mark Vandenberg
Modified: 2014-02-04 17:13 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2014-02-01 09:37:24 UTC
Steps to reproduce

1. Set UI language to German in prefs
2. Go to https://www.wikidata.org/wiki/Q1833362
   (or https://www.wikidata.org/wiki/Q1833362?uselang=?? to simplify
    making an edit in another language, where ?? can be any language code.)
3. Edit the page
   (as it is a species, adding 'Myotis ciliolabrum' as the label 
    to any language is a sensible edit)
4. Visit https://www.wikidata.org/wiki/Q1833362?uselang=en

Expected results:
The UI in step 4 should always be in English.

Actual results:
Parts of the UI are in the UI language of the last contributor to the page; in this case, German.

This is happening to many edits.  Log out and click through the items on https://www.wikidata.org/wiki/Special:RecentChanges which are from someone whose UI language is likely different from 'en'.
Comment 1 John Mark Vandenberg 2014-02-01 09:43:36 UTC
Ah, more steps to see the problem better
5. Change UI language to English
6. Purge the page https://www.wikidata.org/wiki/Q1833362?action=purge

The page UI will be in English again.
Comment 2 Gerrit Notification Bot 2014-02-01 15:26:26 UTC
Change 110694 had a related patch set uploaded by Hoo man:
Prevent WikiPage::doEditContent from adding to the ParserCache

https://gerrit.wikimedia.org/r/110694
Comment 3 Marius Hoch 2014-02-01 15:39:39 UTC
The above is only a workaround, not really a good solution.

See also bug 59693 which is probably caused by the same root problem.
Comment 4 Marius Hoch 2014-02-01 16:04:01 UTC
Found a slightly better solution now... thanks to the ContentHandler.
Comment 5 Gerrit Notification Bot 2014-02-03 11:24:05 UTC
Change 110694 merged by Addshore:
Add EntityHandler::makeParserOptions

https://gerrit.wikimedia.org/r/110694
Comment 6 Gerrit Notification Bot 2014-02-03 11:30:04 UTC
Change 110935 had a related patch set uploaded by Addshore:
Add EntityHandler::makeParserOptions

https://gerrit.wikimedia.org/r/110935
Comment 7 Marius Hoch 2014-02-03 14:35:58 UTC
Patch has been approved, I'll organize a deploy in the next couple of hours.
Comment 8 Gerrit Notification Bot 2014-02-03 15:04:28 UTC
Change 110935 merged by Hoo man:
Add EntityHandler::makeParserOptions

https://gerrit.wikimedia.org/r/110935

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links