Last modified: 2014-11-13 20:45:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62718, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 60718 - VisualEditor: After saving a page, the FlaggedRevs notice "1 change in this version is pending review ..." is not shown


Summary:	VisualEditor: After saving a page, the FlaggedRevs notice "1 change in this v...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	MediaWiki integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2014-11-19 (1.25wmf9)
Assigned To:	Alex Monk

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-02-01 11:46 UTC by Raimond Spekking
Modified:	2014-11-13 20:45 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Raimond Spekking 2014-02-01 11:46:04 UTC

For wikis with FlaggedRevs extension: After saving a page the notice on top of page "1 change in this version is pending review ..." is not shown.

I guess due to not reloading the whole page.

This is a bad experience for every editor w/o reviewer right. No chance to spot that the new revision has to be sighted first.

Comment 1 Alex Monk 2014-11-07 02:14:25 UTC

I took a look into this today... Seems that the review notice is not being made available even as part of the page subtitle to VE.

Comment 2 Alex Monk 2014-11-08 15:14:30 UTC

I came up with some terrible code that successfully achieves this yesterday.

Comment 3 Gerrit Notification Bot 2014-11-12 15:12:40 UTC

Change 172746 had a related patch set uploaded by Alex Monk:
When saving, return the full contentSub to the client

https://gerrit.wikimedia.org/r/172746

Comment 4 Alex Monk 2014-11-12 15:13:35 UTC

(It's slightly less horrible now. But only slightly.)

Comment 5 Gerrit Notification Bot 2014-11-13 20:45:12 UTC

Change 172746 merged by jenkins-bot:
When saving, return the full contentSub to the client

https://gerrit.wikimedia.org/r/172746

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links