Last modified: 2014-03-20 01:54:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62748, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60748 - BetaFeatures: "Automatically enable ..." not working
BetaFeatures: "Automatically enable ..." not working
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
BetaFeatures (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-02 20:02 UTC by Quiddity
Modified: 2014-03-20 01:54 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quiddity 2014-02-02 20:02:28 UTC
The "Automatically enable all new beta features" box isn't working. 

When the BetaFeatures product was first released, there were 4 items available.[1] The additional item "Nearby Pages" has been added since then, but was not automatically enabled in our preferences.

1. https://blog.wikimedia.org/2013/11/07/introducing-beta-features/

Filing on behalf of this thread: https://www.mediawiki.org/wiki/Talk:About_Beta_Features#.22Automatically_enable_all_new_beta_features.22_not_working_.28.3F.29
Comment 1 Quiddity 2014-02-05 22:11:02 UTC
Confirmed - the "New search" BetaFeature was recently added to the options at Enwiki, but not enabled for me, despite having "Automatically enable..." checked.
Comment 2 Quiddity 2014-02-15 19:19:33 UTC
Setting priority and upgrading importance. HTH.
Comment 3 Gerrit Notification Bot 2014-03-04 06:00:28 UTC
Change 116721 had a related patch set uploaded by Legoktm:
Fix typo when getting auto-enroll preference setting

https://gerrit.wikimedia.org/r/116721
Comment 4 Kunal Mehta (Legoktm) 2014-03-04 06:02:57 UTC
Patch fixes the typo which was making this not work.

However, the current code will only enable the new betafeatures when the user visits Special:Preferences, or whenever the 'GetPreferences' hook is run (API's action=options I think). Is that acceptable from a UX point of view?
Comment 5 James Forrester 2014-03-19 01:36:16 UTC
(In reply to Kunal Mehta (Legoktm) from comment #4)
> Patch fixes the typo which was making this not work.

Yay. Marking as FIXED.

> However, the current code will only enable the new betafeatures when the
> user visits Special:Preferences, or whenever the 'GetPreferences' hook is
> run (API's action=options I think). Is that acceptable from a UX point of
> view?

No. Created bug 62815 for that, which is distinct from this issue.
Comment 6 Kunal Mehta (Legoktm) 2014-03-19 05:01:49 UTC
(In reply to James Forrester from comment #5)
> (In reply to Kunal Mehta (Legoktm) from comment #4)
> > Patch fixes the typo which was making this not work.
> 
> Yay. Marking as FIXED.

Patch hasn't been merged yet :/
Comment 7 Gerrit Notification Bot 2014-03-20 01:52:59 UTC
Change 116721 merged by jenkins-bot:
Fix typo when getting auto-enroll preference setting

https://gerrit.wikimedia.org/r/116721
Comment 8 James Forrester 2014-03-20 01:54:14 UTC
(In reply to Kunal Mehta (Legoktm) from comment #6)
> (In reply to James Forrester from comment #5)
> > (In reply to Kunal Mehta (Legoktm) from comment #4)
> > > Patch fixes the typo which was making this not work.
> > 
> > Yay. Marking as FIXED.
> 
> Patch hasn't been merged yet :/

Sorry, thought I'd +2'ed but apparently not.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links