Last modified: 2014-02-13 03:40:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62752, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60752 - Interaction of linktrail and template encapsulation not handled
Interaction of linktrail and template encapsulation not handled
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-03 04:28 UTC by ssastry
Modified: 2014-02-13 03:40 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2014-02-03 04:28:04 UTC
[subbu@earth lib] echo "{{echo|[[Foo]]}}l" | node parse --wt2wt
{{echo|[[Foo]]}}

The wt2wt of that snippet is clearly losing the linktrail from source wikitext. This seems to be because the linktrail/linkprefix DOM pass that runs late in the DOM post-processing stage doesn't update data-mw of the transclusion to include info about the linktrail. See below.

[subbu@earth lib] echo "{{echo|[[Foo]]}}l" | node parse --dump dom:post-encap | & sed "s/"/'/g;"
------ DOM: post-encapsulation -------
<head data-parsoid="{'tmp':{}}"></head><body data-parsoid="{'tmp':{},'dsr':[0,18,0,0]}"><p data-parsoid="{'tagId':1,'tmp':{},'dsr':[0,17,0,0]}"><a rel="mw:WikiLink" href="./Foo" about="#mwt1" typeof="mw:Transclusion" data-mw="{'parts':[{'template':{'target':{'wt':'echo','href':'./Template:Echo'},'params':{'1':{'wt':'[[Foo]]'}},'i':0}}]}" data-parsoid="{'stx':'simple','a':{'href':'./Foo'},'sa':{'href':'Foo'},'tagId':3,'tmp':{},'dsr':[0,16,null,null],'src':'{{echo|[[Foo]]}}','pi':[[{'k':'1','spc':['','','','']}]]}">Foo</a>l</p>
</body>
----------------------------
<body data-parsoid='{"dsr":[0,18,0,0]}'><p data-parsoid='{"dsr":[0,17,0,0]}'><a rel="mw:WikiLink" href="./Foo" about="#mwt1" typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"wt":"echo","href":"./Template:Echo"},"params":{"1":{"wt":"[[Foo]]"}},"i":0}}]}' data-parsoid='{"stx":"simple","a":{"href":"./Foo"},"sa":{"href":"Foo"},"dsr":[0,17,null,1],"pi":[[{"k":"1","spc":["","","",""]}]],"tail":"l"}'>Fool</a></p>
</body>
Comment 2 Gerrit Notification Bot 2014-02-07 04:45:52 UTC
Change 111966 had a related patch set uploaded by Arlolra:
Handle interaction between linktrail and template

https://gerrit.wikimedia.org/r/111966
Comment 3 Gerrit Notification Bot 2014-02-07 05:18:37 UTC
Change 111966 merged by jenkins-bot:
Handle interaction between linktrail and template

https://gerrit.wikimedia.org/r/111966
Comment 4 Gerrit Notification Bot 2014-02-12 18:45:20 UTC
Change 112923 had a related patch set uploaded by Arlolra:
Follow up on linktrail / template interaction

https://gerrit.wikimedia.org/r/112923
Comment 5 Gerrit Notification Bot 2014-02-13 03:35:43 UTC
Change 112923 merged by jenkins-bot:
Follow up on linktrail / template interaction

https://gerrit.wikimedia.org/r/112923

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links