Last modified: 2014-11-10 19:16:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62805, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60805 - CSSJanus only supports flipping one text-shadow or border-shadow in RTL languages while the CSS syntax allows multiple
CSSJanus only supports flipping one text-shadow or border-shadow in RTL langu...
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.23.0
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on: 45677
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-04 02:28 UTC by Isarra
Modified: 2014-11-10 19:16 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Isarra 2014-02-04 02:28:53 UTC
It flipped the y-offset for some reason:

ltr: text-shadow: #333333 0px -1px 1px, #FFFFFF 0px 2px 1px;
rtl: text-shadow: #333333 0px 1px 1px, #FFFFFF 0px 2px 1px;

That was weird. Now of course in that case it needn't flip at all and I can just tell it not to, but this still ain't proper behaviour.
Comment 1 MZMcBride 2014-02-04 03:27:01 UTC
(In reply to comment #0)
> It flipped the y-offset for some reason:
> 
> ltr: text-shadow: #333333 0px -1px 1px, #FFFFFF 0px 2px 1px;
> rtl: text-shadow: #333333 0px 1px 1px, #FFFFFF 0px 2px 1px;

When you say "it flipped," what is "it"?

Is this a ResourceLoader bug?
Comment 2 Isarra 2014-02-04 03:37:24 UTC
See the numbers in the rule? The -1 became a 1. It flipped.

Is resourceloader what flips the interface for rtl languages?
Comment 3 MZMcBride 2014-02-04 05:23:54 UTC
(In reply to comment #2)
> See the numbers in the rule? The -1 became a 1. It flipped.

Yes, the CSS changed (flipped), but what changed it? Where did you see this? What were you doing when this happened? Are there exact steps to reproduce?
Comment 4 Isarra 2014-02-04 06:22:13 UTC
I don't know; where does mw flip the interface css for rtl languages?

I was juggling ostriches on the moon at the time. I suppose to reproduce it you would have to go to the moon and juggle ostriches, then. Oh, and put something like what I pasted above in a file that gets flipped, probably. Unless it really was the ostriches what did it? Now there's a thought.
Comment 5 Andre Klapper 2014-02-04 08:46:33 UTC
URL and screenshot welcome.
Comment 6 Bartosz Dziewoński 2014-02-04 11:16:39 UTC
(In reply to comment #0)
> ltr: text-shadow: #333333 0px -1px 1px, #FFFFFF 0px 2px 1px;
> rtl: text-shadow: #333333 0px 1px 1px, #FFFFFF 0px 2px 1px;

There are two shadows defined here, and ResourceLoader (or actually CSSJanus) only supports flipping the first one in a rule right now. :(

I added the half-baked feature in I97ee7431 to fix bug 45677.

(Rephrasing the summary and moving to a better component.)
Comment 7 Isarra 2014-02-05 00:03:15 UTC
Ah, thanks. That explains it (and why this seemed so familiar, d'oh).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links