Last modified: 2014-11-16 13:17:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62828, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 60828 - Special:SetAliases (or SpecialModifyTerm) should properly validate / normalize label/alias input


Summary:	Special:SetAliases (or SpecialModifyTerm) should properly validate / normaliz...

Status:	NEW

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataClient (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:	https://www.wikidata.org/wiki/Q305819...
Whiteboard:	u=dev c=backend p=0
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-02-04 14:15 UTC by Fomafix
Modified:	2014-11-16 13:17 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshop of https://www.wikidata.org/wiki/Q15709419?uselang=de (95.06 KB, image/png) 2014-02-04 14:15 UTC, Fomafix	Details
Screenshot of https://www.wikidata.org/wiki/Q3058198?uselang=de (62.78 KB, image/png) 2014-10-13 16:07 UTC, Fomafix	Details
Add an attachment (proposed patch, testcase, etc.)

Description Fomafix 2014-02-04 14:15:55 UTC

Created attachment 14481 [details]
Screenshop of https://www.wikidata.org/wiki/Q15709419?uselang=de

I set with https://www.wikidata.org/wiki/Special:SetAliases to the item https://www.wikidata.org/wiki/Q15709419 for the language de the alias " " (U+202F NARROW NO-BREAK SPACE). The interface of the item is now blocked in this language [1]. See screenshot.

[1] https://www.wikidata.org/wiki/Q15709419?uselang=de

Comment 1 Fomafix 2014-02-07 19:32:39 UTC

The item Q15709419 was merged to Q3058198. I set with
https://www.wikidata.org/wiki/Special:SetAliases/Q3058198/de the alias " " (U+202F NARROW NO-BREAK SPACE) again. The problem is still the same.

Not allowed characters are ok, but it should be the same characters everywhere.

Comment 2 Fomafix 2014-10-13 16:07:46 UTC

Created attachment 16755 [details]
Screenshot of https://www.wikidata.org/wiki/Q3058198?uselang=de

Screenshot of https://www.wikidata.org/wiki/Q3058198?uselang=de

The alias with U+202F NARROW NO-BREAK SPACE is still not editable or removable.

Comment 3 Marius Hoch 2014-10-17 20:07:45 UTC

It no longer blocks the interface, but also it's not changeable... that's probably because:

22:07:27.510 $.trim( ' ' /* U+202F NARROW NO-BREAK SPACE */ ) === ''
22:07:27.516 true

Comment 4 Marius Hoch 2014-10-17 20:10:52 UTC

We should probably use a trim function in JS and in PHP which do exactly the same (that might mean making NARROW NO-BREAK SPACE not usable as label/ alias).

Comment 5 Marius Hoch 2014-11-16 13:17:43 UTC

Changing this bug, because it's only a result of invalid data... you shouldn't have been able to set that alias using the special page in the first place.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links