Last modified: 2014-04-17 21:25:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62829, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60829 - More than one HTML comment at the start of a line causes line contents to be passed through without conversion to wikitext
More than one HTML comment at the start of a line causes line contents to be ...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-04 14:51 UTC by Elitre
Modified: 2014-04-17 21:25 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Elitre 2014-02-04 14:51:21 UTC 
At en.wp, Fram provided a description of how to "trick" VE into showing some markup without actually typing it.

<<Start from an "empty" page (it contains some hidden comments, but since you can't remove these with VE...): [https://en.wikipedia.org/w/index.php?title=User:Fram/sandbox&oldid=593249688].

Start a simple article in the normal way, with a header and some text.[https://en.wikipedia.org/w/index.php?title=User%3AFram%2Fsandbox&diff=593249716&oldid=593249688]

Now reopen that page in VE: [https://en.wikipedia.org/w/index.php?title=User:Fram/sandbox&oldid=593249716&veaction=edit] Hey presto, I get <nowiki>== Test ==</nowiki> instead of the actual header appearance, due to the invisible and unremovable hidden comments. >>

I was able to reproduce this, see https://en.wikipedia.org/w/index.php?title=User%3AElitre_%28WMF%29%2FSandbox&diff=593889873&oldid=593889831 .
Comment 1 James Forrester 2014-03-13 02:37:49 UTC 
Works:

| <!--Foo-->==Bar== 

Doesn't work:

| <!--Foo--><!--Foo-->==Bar== 

Sad.
Comment 2 Gerrit Notification Bot 2014-03-31 18:25:20 UTC 
Change 122448 had a related patch set uploaded by Subramanya Sastry:
(Bug 60829) Accept multiple comments in SOL context

https://gerrit.wikimedia.org/r/122448
Comment 3 Gerrit Notification Bot 2014-03-31 19:05:17 UTC 
Change 122448 merged by jenkins-bot:
(Bug 60829) Accept multiple comments in SOL context

https://gerrit.wikimedia.org/r/122448
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links