Last modified: 2014-06-21 19:58:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62846, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60846 - Deprecate Skin::bottomScripts(), move use of SkinAfterBottomScripts hook to OutputPage::getBottomScripts()
Deprecate Skin::bottomScripts(), move use of SkinAfterBottomScripts hook to O...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.22.2
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2014-02-04 20:53 UTC by Mark A. Hershberger
Modified: 2014-06-21 19:58 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark A. Hershberger 2014-02-04 20:53:41 UTC 
Ran into this at [[mw:Thread:Project:Support desk/How to get Piwik code into MobileFrontend?]] and, as a result found this comment right above where the hook is called:

  // TODO and the suckage continues. This function is really just a wrapper around
  // OutputPage::getBottomScripts() which takes a Skin param. This should be
  // cleaned up at some point

Could deprecating Skink::bottomScripts(), and moving the use of the SkinAfterBottomScripts hook to OutputPage::getBottomScripts() fix this?
Comment 1 Mark A. Hershberger 2014-02-05 15:02:32 UTC 
This doesn't really change functionality and it fixes a problem with some extensions (interaction of MobileFrontend and Piwik in this case.

If it is ok, I'd like to target the next 1.22 point release.
Comment 2 Mark A. Hershberger 2014-06-21 19:58:02 UTC 
Removing target milestone that was in the past.

If you want this in a specific release, have a good reason AND you are willing to find resources to fix this bug, feel free to change it to something appropriate.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links