Last modified: 2014-07-22 00:03:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62848, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60848 - Sometimes closing an overlay triggers browser back behavior
Sometimes closing an overlay triggers browser back behavior
Status: RESOLVED WONTFIX
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Unprioritized enhancement
: ---
Assigned To: Nobody - You can work on this!
:
: 61966 64686 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-04 21:12 UTC by Ryan Kaldari
Modified: 2014-07-22 00:03 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2014-02-04 21:12:19 UTC
Go to http://en.m.wikipedia.beta.wmflabs.org/wiki/0.28647961229659646#/notifications and click the close button.

Expected behavior: The overlay closes and you see the article.

Actual behavior: Your browser goes back to the previous page that was loaded before.
Comment 1 Bingle 2014-02-04 21:20:24 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1666
Comment 2 Juliusz Gonera 2014-02-04 22:52:33 UTC
If you type that link directly in the browser then unfortunately that's what will happen. It basically goes to the previous item in browser's history.
Comment 3 Jon 2014-02-05 06:08:43 UTC
To be fair that's how the web works... not sure we should complicate things by trying to change that. I'd suggest this is a WONTFIX...

If you followed a link to the editor from twitter would you expect back to take you to the article or back to the tweet on twitter? probably the latter.
Comment 4 Ryan Kaldari 2014-02-05 18:19:13 UTC
If we're going to treat overlays as pages rather than overlays, the interface should reflect that. In other words, we should be using back arrows instead of close 'x's. Otherwise the behavior is confusing.
Comment 5 Brandon Harris 2014-02-05 20:04:38 UTC
I suppose my first question is this:  Is it implemented as an overlay, or as a new page?

If it's a 'true' overlay, then it should just dismiss.  However, it sounds like it's handled as a whole page, in which case I should think it behaves like a page (and thus would have an arrow rather than a close).
Comment 6 Kaity Hammerstein 2014-02-05 20:14:31 UTC
In the future especially for tablet we'll treat them more as overlays - notifications will look more like it does on desktop. On desktop if you open notifications, then click back, you're taken to the previous page - because you can still see the current page underneath. I think it should behave the same way on mobile.
Comment 7 kenan wang 2014-02-06 03:02:17 UTC
Yes I would expect it to close the notifications so you can see the article.
Comment 8 Jon 2014-02-26 22:42:10 UTC
*** Bug 61966 has been marked as a duplicate of this bug. ***
Comment 9 Jon 2014-03-04 18:50:06 UTC
After discussing this with Juliusz, Kenan, Max, Arthur and Ryan we agreed that we would not break the web and that each URL would be treated as a separate identity. If a page links to the issues on an article we should load the issues for that article and clicking back should take them to the page that linked to it.

We are not willing to jeopardize the back button behaviour in the normal case.

We will revisit this if we get any complaints which bring new light to this. Currently it is only a minor inconvenience.
Comment 10 Jon 2014-05-01 01:45:42 UTC
*** Bug 64686 has been marked as a duplicate of this bug. ***
Comment 11 Ryan Kaldari 2014-07-22 00:00:06 UTC
*** Bug 65041 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links