Last modified: 2014-02-14 07:40:57 UTC
See url, also screenshot provided by a user: http://i.imgur.com/2Vsq8V8.png. Not sure what caused it, but it shouldn't break Echo because the notification can't be formatted.
\Flow\NotificationFormatter::getLinkParams calls \Flow\UrlGenerator::generateUrlData which is throwing InvalidInputException's.
Created attachment 14496 [details] Patch Hack-ish patch, but fixes the bug. Someone who knows this part of the code better could probably come up with a better fix.
Change 111484 had a related patch set uploaded by EBernhardson: Catch exceptions formatting notifications https://gerrit.wikimedia.org/r/111484
Also https://gerrit.wikimedia.org/r/#/c/111495/ Echo change to prevent insertion of too much stuff.
Change 111625 had a related patch set uploaded by EBernhardson: Prevent fatal errors in urlgenerator https://gerrit.wikimedia.org/r/111625
Change 111625 merged by jenkins-bot: Prevent fatal errors in urlgenerator https://gerrit.wikimedia.org/r/111625
Change 111614 had a related patch set uploaded by Matthias Mullie: (bug 60906) Truncate content before storing event into DB https://gerrit.wikimedia.org/r/111614
Change 111484 merged by jenkins-bot: Catch exceptions formatting notifications https://gerrit.wikimedia.org/r/111484
Change 111649 had a related patch set uploaded by Matthias Mullie: (bug 60906) Truncate content before storing event into DB https://gerrit.wikimedia.org/r/111649
Change 111614 abandoned by Matthias Mullie: (bug 60906) Truncate content before storing event into DB Reason: Pushed anew, against master https://gerrit.wikimedia.org/r/111614
Change 111654 had a related patch set uploaded by EBernhardson: Catch exceptions formatting notifications https://gerrit.wikimedia.org/r/111654
Change 111656 had a related patch set uploaded by EBernhardson: Catch exceptions formatting notifications https://gerrit.wikimedia.org/r/111656
Change 111654 merged by jenkins-bot: Catch exceptions formatting notifications https://gerrit.wikimedia.org/r/111654
Change 111656 merged by jenkins-bot: Catch exceptions formatting notifications https://gerrit.wikimedia.org/r/111656
Change 111658 had a related patch set uploaded by EBernhardson: Prevent fatal errors in urlgenerator https://gerrit.wikimedia.org/r/111658
Change 111658 merged by jenkins-bot: Prevent fatal errors in urlgenerator https://gerrit.wikimedia.org/r/111658
Change 111659 had a related patch set uploaded by EBernhardson: Prevent fatal errors in urlgenerator https://gerrit.wikimedia.org/r/111659
Change 111659 merged by jenkins-bot: Prevent fatal errors in urlgenerator https://gerrit.wikimedia.org/r/111659
deployed to 1.23wmf11 and 1.23wmf12. There is still a minor inconsistency, notifications that fail rendering will stay 'unread'
Change 111706 had a related patch set uploaded by Legoktm: Don't throw exceptions in the Echo formatter https://gerrit.wikimedia.org/r/111706
Change 111706 abandoned by Legoktm: Don't throw exceptions in the Echo formatter Reason: I didn't mean to commit this... https://gerrit.wikimedia.org/r/111706
Sorry, my mistake.
Change 111649 merged by jenkins-bot: (bug 60906) Truncate content before storing event into DB https://gerrit.wikimedia.org/r/111649
Change 112730 had a related patch set uploaded by EBernhardson: (bug 60906) Truncate content before storing event into DB https://gerrit.wikimedia.org/r/112730
Change 112730 merged by jenkins-bot: (bug 60906) Truncate content before storing event into DB https://gerrit.wikimedia.org/r/112730
