Last modified: 2014-02-20 19:05:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62947, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60947 - Flow: regression: "Show changes" compare-revisions gets diff error
Flow: regression: "Show changes" compare-revisions gets diff error
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.beta.wmflabs.org/...
:
: 61098 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-06 09:04 UTC by spage
Modified: 2014-02-20 19:05 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-02-06 09:04:46 UTC
Find any edited post on ee-flow or beta-wiki, click its mini-pencil icon and choose Show changes, every time I get an error:
  Error
  Diff operation can only be done for two revisions belonging to the same post."

I just made and edited (as Selenium user) on Talk:Sandbox the "New post, test edit" post under "New topic, test edit"

http://ee-flow.wmflabs.org/w/index.php?title=Talk:Sandbox&topic_newRevision=05101971fe9de08a3c1bfa163e68c4ac&topic_oldRevision=0510195fc1a1e08a3c1bfa163e68c4ac&workflow=0510195fc195e08a3c1bfa163e68c4ac&action=compare-revisions

The fix for bug 56196 changed query string parameter names from [] to _. If I change the _ back to [], I see the diff fine:

http://ee-flow.wmflabs.org/w/index.php?title=Talk:Sandbox&topic[newRevision]=05101971fe9de08a3c1bfa163e68c4ac&topic[oldRevision]=0510195fc1a1e08a3c1bfa163e68c4ac&workflow=0510195fc195e08a3c1bfa163e68c4ac&action=compare-revisions
Comment 1 Gerrit Notification Bot 2014-02-06 17:31:35 UTC
Change 111823 had a related patch set uploaded by EBernhardson:
Properly parse out underscored parameters

https://gerrit.wikimedia.org/r/111823
Comment 2 Gerrit Notification Bot 2014-02-06 17:32:08 UTC
Change 111823 merged by jenkins-bot:
Properly parse out underscored parameters

https://gerrit.wikimedia.org/r/111823
Comment 3 Quiddity 2014-02-08 22:11:01 UTC
*** Bug 61098 has been marked as a duplicate of this bug. ***
Comment 4 Gerrit Notification Bot 2014-02-11 18:33:49 UTC
Change 112729 had a related patch set uploaded by EBernhardson:
Properly parse out underscored parameters

https://gerrit.wikimedia.org/r/112729
Comment 5 Gerrit Notification Bot 2014-02-11 18:36:13 UTC
Change 112729 merged by jenkins-bot:
Properly parse out underscored parameters

https://gerrit.wikimedia.org/r/112729
Comment 6 spage 2014-02-20 19:05:03 UTC
(Gerrit change #112729 was a backport to 1.23wmf13)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links