Last modified: 2014-06-01 17:16:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62962, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60962 - Primary keys and fields that reference them should be unsigned
Primary keys and fields that reference them should be unsigned
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.23.0
All All
: Lowest minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: schema-change
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-06 13:51 UTC by Nathan Larson
Modified: 2014-06-01 17:16 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nathan Larson 2014-02-06 13:51:30 UTC
rc_id will hit its max at 2147483647 rather than 4294967295 because it's an int rather than an unsigned int. Therefore, it should be changed to unsigned.

Maybe this is also a good opportunity to change it to an unsigned bigint, since it's at 600 million already on enwiki and at the current rate of increase could reach its limit in our lifetime.
Comment 1 Nathan Larson 2014-02-06 16:09:16 UTC
Some fields that should be unsigned, that aren't:
*change_tag.ct_rc_id
*change_tag.ct_log_id
*change_tag.ct_rev_id
*filearchive.fa_id
*filearchive.fa_deleted_user
*ipblocks.ipb_id
*page_props.pp_page
*page_restrictions.pr_page
*recentchanges.rc_id
*tag_summary.ts_rc_id
*tag_summary.ts_log_id
*tag_summary.ts_rev_id
*user_newtalk.user_id
*user_properties.up_user
Comment 2 Nathan Larson 2014-02-09 15:53:47 UTC
See also bug 61111, proposing changing primary keys to bigint unsigned.
Comment 3 Nathan Larson 2014-02-12 00:01:39 UTC
112825
Comment 4 Nathan Larson 2014-02-12 00:02:02 UTC
Gerrit change #112825
Comment 5 Gerrit Notification Bot 2014-06-01 17:16:22 UTC
Change 112825 had a related patch set uploaded by MZMcBride:
Make the following fields int unsigned:

https://gerrit.wikimedia.org/r/112825

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links