Last modified: 2014-02-07 20:01:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62969, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 60969 - VisualEditor: Format action applies to nodes inside handlesOwnChildren node


Summary:	VisualEditor: Format action applies to nodes inside handlesOwnChildren node

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Data Model (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2014-02-13
Assigned To:	Ed Sanders

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-02-06 16:29 UTC by Ed Sanders
Modified:	2014-02-07 20:01 UTC (History)
CC List:	5 users (show)

See Also:	60804
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2014-02-06 16:29:59 UTC

1. Select a block image with caption
2. Press the list button

Expected:
Either nothing, or a list is created above/below the image

Observed:
The caption is wrapped in a list

Clearly we need to ignore nodes which are inside handlesOwnChildren nodes when applying such actions.

Comment 1 Gerrit Notification Bot 2014-02-06 17:28:47 UTC

Change 111822 had a related patch set uploaded by Esanders:
Don't descend into handlesOwnChildren nodes in selectNodes

https://gerrit.wikimedia.org/r/111822

Comment 2 James Forrester 2014-02-06 17:40:10 UTC

I'm assuming that bug 60804 the same issue.

Comment 3 Gerrit Notification Bot 2014-02-07 19:59:43 UTC

Change 111822 merged by jenkins-bot:
Don't descend into handlesOwnChildren nodes in selectNodes

https://gerrit.wikimedia.org/r/111822

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links