Last modified: 2014-03-14 00:05:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63155, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61155 - VisualEditor: Selecting border in Media Settings>Advanced Settings does not add any value to the image type field
VisualEditor: Selecting border in Media Settings>Advanced Settings does not a...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-03-06
Assigned To: Moriel Schottlender
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-10 20:27 UTC by Rummana Yasmeen
Modified: 2014-03-14 00:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (142.19 KB, image/png)
2014-02-27 22:15 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-02-10 20:27:18 UTC 
Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Go to Media Settings>Advanced Settings for that image
4.Select the option Border under Image Type

Observed Result:
There is no value/Change appears for this image type
The resulting wikitext is:
[[File:Wheat (flo).JPG|200x200px||left]]

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=10thFeb&action=edit
Comment 1 Moriel Schottlender 2014-02-11 21:58:59 UTC 
Cannot replicate in master in both Chrome 32 and Firefox 27 under Ubuntu.
Comment 2 Moriel Schottlender 2014-02-11 23:19:44 UTC 
Found the bug, the wikitext doesn't have |border even though the CE is updated.

This commit seems to fix it: https://gerrit.wikimedia.org/r/#/c/112041/
Comment 3 Gerrit Notification Bot 2014-02-11 23:46:04 UTC 
Change 112041 had a related patch set uploaded by Jforrester:
Revamp media edit dialog's position widget

https://gerrit.wikimedia.org/r/112041
Comment 4 Gerrit Notification Bot 2014-02-20 23:51:03 UTC 
Change 112041 merged by jenkins-bot:
Revamp media edit dialog's position widget

https://gerrit.wikimedia.org/r/112041
Comment 5 Rummana Yasmeen 2014-02-27 22:15:04 UTC 
Still not working for me.I could still reproduce it in page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=27thfebff&action=edit

See the screenshot attached
Comment 6 Rummana Yasmeen 2014-02-27 22:15:31 UTC 
Created attachment 14708 [details]
Screenshot
Comment 7 Gerrit Notification Bot 2014-02-28 23:07:33 UTC 
Change 115939 had a related patch set uploaded by Mooeypoo:
[wip] Deal with 'none'/'border' and default size in media edit

https://gerrit.wikimedia.org/r/115939
Comment 8 Gerrit Notification Bot 2014-03-05 19:11:25 UTC 
Change 115939 merged by jenkins-bot:
Deal with 'none'/'border' and default size in media edit

https://gerrit.wikimedia.org/r/115939
Comment 9 Rummana Yasmeen 2014-03-05 20:39:35 UTC 
Verified the fix in Betalabs
Comment 10 Rummana Yasmeen 2014-03-07 21:49:37 UTC 
Verified the fix in test2
Comment 11 Rummana Yasmeen 2014-03-14 00:05:38 UTC 
Verified the fix in production:https://en.wikipedia.org/w/index.php?title=User:RYasmeen_%28WMF%29/sandbox&veaction=edit
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links