Last modified: 2014-11-16 03:53:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63227, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61227 - Migrate memcache serialization from igbinary
Migrate memcache serialization from igbinary
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: hhvm
Depends on:
Blocks: 56596
  Show dependency treegraph
 
Reported: 2014-02-11 18:49 UTC by Ori Livneh
Modified: 2014-11-16 03:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2014-02-11 18:49:14 UTC
HHVM ships with an lz4 compression library -- see <https://github.com/facebook/hhvm/tree/master/hphp/third_party/lz4>. Is it a viable replacement for igbinary serialization? It would require a complicate migration in production, but I suspect the overall effort required would be less than adding igbinary support for HHVM.
Comment 1 Ori Livneh 2014-03-05 20:42:05 UTC
We should stick with igbinary for now. Aaron has agreed to try to port it.
Comment 2 Ori Livneh 2014-03-19 21:57:01 UTC
We don't need to port it.

MemcachedPeclBagOStuff stores the serializer in the bitfield accompanying each value, and will use the correct deserializer regardless of which serializer is currently configured. Switching to the PHP serializer means any new keys written from now on will use PHP serialization, while existing values will continue to be readable.

We've done this for Labs already.

TODOs:
* Make the switch in prod
* Devise a tool for assessing % of keys that still use igbinary (for example, tcpdump 1 min of memcached GETs and check each key's serialization flag)
Comment 3 Gerrit Notification Bot 2014-03-19 21:58:06 UTC
Change 119461 had a related patch set uploaded by Ori.livneh:
Set serializer to 'php' for production memcache

https://gerrit.wikimedia.org/r/119461
Comment 4 Gerrit Notification Bot 2014-03-19 22:27:12 UTC
Change 119461 merged by Ori.livneh:
Set serializer to 'php' for production memcache

https://gerrit.wikimedia.org/r/119461
Comment 5 Aaron Schulz 2014-04-18 00:16:33 UTC
Getting close to the 30 day mark of the conf change in https://bugzilla.wikimedia.org/show_bug.cgi?id=61227. Since parser cache is stored for 30 days (longer than most other stuff, rev cache is only 7) then most cache entries should be in the new format by now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links