Last modified: 2014-02-12 18:41:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63247, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61247 - Flow: browser tests Action menu problem
Flow: browser tests Action menu problem
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-12 02:52 UTC by spage
Modified: 2014-02-12 18:41 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-02-12 02:52:08 UTC
Browser tests are sometimes failing waiting for actions to appear, e.g.
https://saucelabs.com/jobs/4af26fb0dae64f68afbb6e50aa5c2254 failed with

  Create new topic logged in "timed out after 5 seconds, waiting for {:css=>"div.tipsy-inner input.flow-hide-topic-link"} to become present (Watir::Wait::TimeoutError)",

and locally tests failed with
   Then I should see a Hide button    # features/step_definitions/flow_steps.rb:104
   timed out after 5 seconds, waiting for {:css=>"div.tipsy-inner input.flow-hide-post-link"} to become present (Watir::Wait::TimeoutError)
   features/flow_logged_in.feature:30:in `Then I should see a Hide button'

In both cases an action menu appears but it's the wrong one.

The prior step is "When I click the Topic Actions link" or "And I click Actions", and in flow_pager.rb, the topic_actions_link and actions_link page elements are both just text: "Actions". So the browser might click the wrong actions item; it's complicated by the topic_index/action_index variable that points Firefox and Chrome at different topics and posts.

I think the topic_actions_link and actions_link page elements need to target the right actions button, e.g. with
  css ".flow-topic-title" text "Actions"
and 
  css ".flow-post-container" text "Actions"
Comment 1 Gerrit Notification Bot 2014-02-12 07:39:36 UTC
Change 112858 had a related patch set uploaded by Spage:
Specify which Actions menu, Topic or Post

https://gerrit.wikimedia.org/r/112858
Comment 2 Gerrit Notification Bot 2014-02-12 18:18:01 UTC
Change 112858 merged by Cmcmahon:
Specify which Actions menu, Topic or Post

https://gerrit.wikimedia.org/r/112858
Comment 3 Chris McMahon 2014-02-12 18:41:45 UTC
tested, commented, and merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links